Cleanup return values in autofill

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 657 matching lines @@
 
   return element->isCheckbox() || element->isRadioButton();
 }
 
 bool IsAutofillableInputElement(const WebInputElement* element) {
   return IsTextInput(element) ||
          IsMonthInput(element) ||
          IsCheckableElement(element);
 }
 
-const base::string16 GetFormIdentifier(const WebFormElement& form) {
+const base::string16& GetFormIdentifier(const WebFormElement& form) {

[vabr (Chromium), 2014/07/11 13:37:43]

Here returning a reference won't work, because the object returned lives on the
local stack and goes out of scope after returning.
Please return a (non-const) string16 by value instead.

[Ilya Sherman, 2014/07/11 19:11:10]

As I mentioned on the bug, the const here is correct.  It prevents a class of
improbable but very surprising code snippets from compiling.

[vabr (Chromium), 2014/07/11 19:24:47]

Thanks for pointing that out.
Let's revert the changes to form_autofill_util.*, then.

[lucinka.brozkova, 2014/07/11 21:05:57]

Done.

   base::string16 identifier = form.name();
   CR_DEFINE_STATIC_LOCAL(WebString, kId, ("id"));
   if (identifier.empty())
     identifier = form.getAttribute(kId);
 
   return identifier;
 }
 
 bool IsWebNodeVisible(const blink::WebNode& node) {
   // In the bug http://crbug.com/237216 the form's bounding box is empty
@@ skipping 493 matching lines @@
 
 gfx::RectF GetScaledBoundingBox(float scale, WebFormControlElement* element) {
   gfx::Rect bounding_box(element->boundsInViewportSpace());
   return gfx::RectF(bounding_box.x() * scale,
                     bounding_box.y() * scale,
                     bounding_box.width() * scale,
                     bounding_box.height() * scale);
 }
 
 }  // namespace autofill