Cleanup return values in autofill

components/autofill/content/renderer/form_autofill_util.h

Index: components/autofill/content/renderer/form_autofill_util.h
diff --git a/components/autofill/content/renderer/form_autofill_util.h b/components/autofill/content/renderer/form_autofill_util.h
index 0f0f6c2e134ba13cfde638658a9925f5056605d8..a976d3aaf212cea708cdfc4e78f38ce2d0a2a589 100644
--- a/components/autofill/content/renderer/form_autofill_util.h
+++ b/components/autofill/content/renderer/form_autofill_util.h
@@ -77,7 +77,7 @@ bool IsWebNodeVisible(const blink::WebNode& node);
 
 // Returns the form's |name| attribute if non-empty; otherwise the form's |id|
 // attribute.
-const base::string16 GetFormIdentifier(const blink::WebFormElement& form);
+const base::string16& GetFormIdentifier(const blink::WebFormElement& form);

[vabr (Chromium), 2014/07/11 13:37:43]

Could this method be const?

[Ilya Sherman, 2014/07/11 19:11:10]

This is a free function, not a method.

[vabr (Chromium), 2014/07/11 19:24:47]

Ah thanks, my bad for missing that.
I take my earlier comment back, since it does not make any sense.

[lucinka.brozkova, 2014/07/11 21:05:57]

Acknowledged.

 
 // Returns true if the element specified by |click_element| was successfully
 // clicked.