Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 381633002: Use a register spec for StoreIC and KeyedStoreIC. (Closed)

Created:
6 years, 5 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use a register spec for StoreIC and KeyedStoreIC. This continues refactoring already applied for LoadIC in r22035 (https://code.google.com/p/v8/source/detail?r=22035). R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22328

Patch Set 1 : With ports. #

Patch Set 2 : Minor fixes. #

Total comments: 4

Patch Set 3 : Code comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -729 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/arm/debug-arm.cc View 2 chunks +11 lines, -15 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 8 chunks +19 lines, -16 lines 0 comments Download
M src/arm/ic-arm.cc View 1 11 chunks +50 lines, -79 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M src/arm64/debug-arm64.cc View 2 chunks +12 lines, -16 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 8 chunks +20 lines, -17 lines 0 comments Download
M src/arm64/ic-arm64.cc View 12 chunks +37 lines, -71 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 8 chunks +20 lines, -18 lines 0 comments Download
M src/ia32/ic-ia32.cc View 22 chunks +147 lines, -173 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/ic.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 8 chunks +20 lines, -18 lines 0 comments Download
M src/x64/ic-x64.cc View 1 2 20 chunks +125 lines, -146 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Jakob, Here is the refactoring we talked about. Thx for the look! --Michael
6 years, 5 months ago (2014-07-10 11:50:02 UTC) #1
Jakob Kummerow
LGTM. I less than three this! https://codereview.chromium.org/381633002/diff/60001/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://codereview.chromium.org/381633002/diff/60001/src/ia32/ic-ia32.cc#newcode970 src/ia32/ic-ia32.cc:970: static void LoadIC_PushArgs(MacroAssembler* ...
6 years, 5 months ago (2014-07-10 13:42:06 UTC) #2
mvstanton
6 years, 5 months ago (2014-07-10 15:00:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r22328.

Powered by Google App Engine
This is Rietveld 408576698