Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 381633002: Use a register spec for StoreIC and KeyedStoreIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1293 Register* KeyedLoadStubCompiler::registers() { 1293 Register* KeyedLoadStubCompiler::registers() {
1294 // receiver, name, scratch1, scratch2, scratch3, scratch4. 1294 // receiver, name, scratch1, scratch2, scratch3, scratch4.
1295 Register receiver = LoadIC::ReceiverRegister(); 1295 Register receiver = LoadIC::ReceiverRegister();
1296 Register name = LoadIC::NameRegister(); 1296 Register name = LoadIC::NameRegister();
1297 static Register registers[] = { receiver, name, ebx, eax, edi, no_reg }; 1297 static Register registers[] = { receiver, name, ebx, eax, edi, no_reg };
1298 return registers; 1298 return registers;
1299 } 1299 }
1300 1300
1301 1301
1302 Register StoreStubCompiler::value() { 1302 Register StoreStubCompiler::value() {
1303 return eax; 1303 return StoreIC::ValueRegister();
1304 } 1304 }
1305 1305
1306 1306
1307 Register* StoreStubCompiler::registers() { 1307 Register* StoreStubCompiler::registers() {
1308 // receiver, name, scratch1, scratch2, scratch3. 1308 // receiver, name, scratch1, scratch2, scratch3.
1309 static Register registers[] = { edx, ecx, ebx, edi, no_reg }; 1309 Register receiver = StoreIC::ReceiverRegister();
1310 Register name = StoreIC::NameRegister();
1311 static Register registers[] = { receiver, name, ebx, edi, no_reg };
1310 return registers; 1312 return registers;
1311 } 1313 }
1312 1314
1313 1315
1314 Register* KeyedStoreStubCompiler::registers() { 1316 Register* KeyedStoreStubCompiler::registers() {
1315 // receiver, name, scratch1, scratch2, scratch3. 1317 // receiver, name, scratch1, scratch2, scratch3.
1316 static Register registers[] = { edx, ecx, ebx, edi, no_reg }; 1318 Register receiver = KeyedStoreIC::ReceiverRegister();
1319 Register name = KeyedStoreIC::NameRegister();
1320 static Register registers[] = { receiver, name, ebx, edi, no_reg };
1317 return registers; 1321 return registers;
1318 } 1322 }
1319 1323
1320 1324
1321 #undef __ 1325 #undef __
1322 #define __ ACCESS_MASM(masm) 1326 #define __ ACCESS_MASM(masm)
1323 1327
1324 1328
1325 void LoadStubCompiler::GenerateLoadViaGetter(MacroAssembler* masm, 1329 void LoadStubCompiler::GenerateLoadViaGetter(MacroAssembler* masm,
1326 Handle<HeapType> type, 1330 Handle<HeapType> type,
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1491 // ----------------------------------- 1495 // -----------------------------------
1492 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1496 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1493 } 1497 }
1494 1498
1495 1499
1496 #undef __ 1500 #undef __
1497 1501
1498 } } // namespace v8::internal 1502 } } // namespace v8::internal
1499 1503
1500 #endif // V8_TARGET_ARCH_IA32 1504 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698