Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 381633002: Use a register spec for StoreIC and KeyedStoreIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) { 181 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
182 // Register state for IC load call (from ic-ia32.cc). 182 // Register state for IC load call (from ic-ia32.cc).
183 Register receiver = LoadIC::ReceiverRegister(); 183 Register receiver = LoadIC::ReceiverRegister();
184 Register name = LoadIC::NameRegister(); 184 Register name = LoadIC::NameRegister();
185 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0, false); 185 Generate_DebugBreakCallHelper(masm, receiver.bit() | name.bit(), 0, false);
186 } 186 }
187 187
188 188
189 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 189 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
190 // Register state for IC store call (from ic-ia32.cc). 190 // Register state for IC store call (from ic-ia32.cc).
191 // ----------- S t a t e ------------- 191 Register receiver = StoreIC::ReceiverRegister();
192 // -- eax : value 192 Register name = StoreIC::NameRegister();
193 // -- ecx : name 193 Register value = StoreIC::ValueRegister();
194 // -- edx : receiver
195 // -----------------------------------
196 Generate_DebugBreakCallHelper( 194 Generate_DebugBreakCallHelper(
197 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false); 195 masm, receiver.bit() | name.bit() | value.bit(), 0, false);
198 } 196 }
199 197
200 198
201 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 199 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
202 // Register state for keyed IC load call (from ic-ia32.cc). 200 // Register state for keyed IC load call (from ic-ia32.cc).
203 GenerateLoadICDebugBreak(masm); 201 GenerateLoadICDebugBreak(masm);
204 } 202 }
205 203
206 204
207 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 205 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
208 // Register state for keyed IC load call (from ic-ia32.cc). 206 // Register state for keyed IC store call (from ic-ia32.cc).
209 // ----------- S t a t e ------------- 207 Register receiver = KeyedStoreIC::ReceiverRegister();
210 // -- eax : value 208 Register name = KeyedStoreIC::NameRegister();
211 // -- ecx : key 209 Register value = KeyedStoreIC::ValueRegister();
212 // -- edx : receiver
213 // -----------------------------------
214 Generate_DebugBreakCallHelper( 210 Generate_DebugBreakCallHelper(
215 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false); 211 masm, receiver.bit() | name.bit() | value.bit(), 0, false);
216 } 212 }
217 213
218 214
219 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 215 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
220 // Register state for CompareNil IC 216 // Register state for CompareNil IC
221 // ----------- S t a t e ------------- 217 // ----------- S t a t e -------------
222 // -- eax : value 218 // -- eax : value
223 // ----------------------------------- 219 // -----------------------------------
224 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false); 220 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false);
225 } 221 }
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 } 317 }
322 318
323 319
324 const bool LiveEdit::kFrameDropperSupported = true; 320 const bool LiveEdit::kFrameDropperSupported = true;
325 321
326 #undef __ 322 #undef __
327 323
328 } } // namespace v8::internal 324 } } // namespace v8::internal
329 325
330 #endif // V8_TARGET_ARCH_IA32 326 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698