Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 381633002: Use a register spec for StoreIC and KeyedStoreIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/ia32/lithium-codegen-ia32.h" 10 #include "src/ia32/lithium-codegen-ia32.h"
(...skipping 2269 matching lines...) Expand 10 before | Expand all | Expand 10 after
2280 instr->key()->representation(), elements_kind); 2280 instr->key()->representation(), elements_kind);
2281 LOperand* key = clobbers_key 2281 LOperand* key = clobbers_key
2282 ? UseTempRegister(instr->key()) 2282 ? UseTempRegister(instr->key())
2283 : UseRegisterOrConstantAtStart(instr->key()); 2283 : UseRegisterOrConstantAtStart(instr->key());
2284 return new(zone()) LStoreKeyed(backing_store, key, val); 2284 return new(zone()) LStoreKeyed(backing_store, key, val);
2285 } 2285 }
2286 2286
2287 2287
2288 LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) { 2288 LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) {
2289 LOperand* context = UseFixed(instr->context(), esi); 2289 LOperand* context = UseFixed(instr->context(), esi);
2290 LOperand* object = UseFixed(instr->object(), edx); 2290 LOperand* object = UseFixed(instr->object(),
2291 LOperand* key = UseFixed(instr->key(), ecx); 2291 KeyedStoreIC::ReceiverRegister());
2292 LOperand* value = UseFixed(instr->value(), eax); 2292 LOperand* key = UseFixed(instr->key(), KeyedStoreIC::NameRegister());
2293 LOperand* value = UseFixed(instr->value(), KeyedStoreIC::ValueRegister());
2293 2294
2294 ASSERT(instr->object()->representation().IsTagged()); 2295 ASSERT(instr->object()->representation().IsTagged());
2295 ASSERT(instr->key()->representation().IsTagged()); 2296 ASSERT(instr->key()->representation().IsTagged());
2296 ASSERT(instr->value()->representation().IsTagged()); 2297 ASSERT(instr->value()->representation().IsTagged());
2297 2298
2298 LStoreKeyedGeneric* result = 2299 LStoreKeyedGeneric* result =
2299 new(zone()) LStoreKeyedGeneric(context, object, key, value); 2300 new(zone()) LStoreKeyedGeneric(context, object, key, value);
2300 return MarkAsCall(result, instr); 2301 return MarkAsCall(result, instr);
2301 } 2302 }
2302 2303
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
2384 2385
2385 // We need a temporary register for write barrier of the map field. 2386 // We need a temporary register for write barrier of the map field.
2386 LOperand* temp_map = needs_write_barrier_for_map ? TempRegister() : NULL; 2387 LOperand* temp_map = needs_write_barrier_for_map ? TempRegister() : NULL;
2387 2388
2388 return new(zone()) LStoreNamedField(obj, val, temp, temp_map); 2389 return new(zone()) LStoreNamedField(obj, val, temp, temp_map);
2389 } 2390 }
2390 2391
2391 2392
2392 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2393 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2393 LOperand* context = UseFixed(instr->context(), esi); 2394 LOperand* context = UseFixed(instr->context(), esi);
2394 LOperand* object = UseFixed(instr->object(), edx); 2395 LOperand* object = UseFixed(instr->object(), StoreIC::ReceiverRegister());
2395 LOperand* value = UseFixed(instr->value(), eax); 2396 LOperand* value = UseFixed(instr->value(), StoreIC::ValueRegister());
2396 2397
2397 LStoreNamedGeneric* result = 2398 LStoreNamedGeneric* result =
2398 new(zone()) LStoreNamedGeneric(context, object, value); 2399 new(zone()) LStoreNamedGeneric(context, object, value);
2399 return MarkAsCall(result, instr); 2400 return MarkAsCall(result, instr);
2400 } 2401 }
2401 2402
2402 2403
2403 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2404 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2404 LOperand* context = UseFixed(instr->context(), esi); 2405 LOperand* context = UseFixed(instr->context(), esi);
2405 LOperand* left = UseFixed(instr->left(), edx); 2406 LOperand* left = UseFixed(instr->left(), edx);
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
2668 LOperand* function = UseRegisterAtStart(instr->function()); 2669 LOperand* function = UseRegisterAtStart(instr->function());
2669 LAllocateBlockContext* result = 2670 LAllocateBlockContext* result =
2670 new(zone()) LAllocateBlockContext(context, function); 2671 new(zone()) LAllocateBlockContext(context, function);
2671 return MarkAsCall(DefineFixed(result, esi), instr); 2672 return MarkAsCall(DefineFixed(result, esi), instr);
2672 } 2673 }
2673 2674
2674 2675
2675 } } // namespace v8::internal 2676 } } // namespace v8::internal
2676 2677
2677 #endif // V8_TARGET_ARCH_IA32 2678 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698