Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 377373003: Merge Replay and Quilt tasks, adding in all BBH implementations. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Merge Replay and Quilt tasks, adding in all BBH implementations. Replay isn't that helpful of a test any more now that we have the more stringent Quilt tests. Quilt was missing bounding box hierarchies, though, while Replay was sort of testing RTree (pointlessly, as it was drawing without any clip). Now Quilt does everything, testing RTree, QuadTree, and TileGrid. Quilt mode now falls back to drawing all at once (i.e. Replay) for GMs that don't tile perfectly. Still a TODO to make this check more flexible than exact pixel matches. Two GMs fail when using a BBH: - imageresizetiled - resizeimagefilter We think we're not adjusting the bounds of save layers by their paint. This is probably a bug, but one to be fixed separately from adding new tests. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e4636aa17307b00c76e228fc5ddda1bd4904e0dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -123 lines) Patch
M dm/DMCpuGMTask.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M dm/DMQuiltTask.h View 1 chunk +5 lines, -2 lines 0 comments Download
M dm/DMQuiltTask.cpp View 3 chunks +48 lines, -20 lines 0 comments Download
D dm/DMReplayTask.h View 1 chunk +0 lines, -40 lines 0 comments Download
D dm/DMReplayTask.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M dm/DMSKPTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gm/imageresizetiled.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/dm.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 5 months ago (2014-07-09 19:37:39 UTC) #1
robertphillips
lgtm Maybe create a bug for the discovered problems?
6 years, 5 months ago (2014-07-09 19:44:53 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-09 19:54:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/377373003/1
6 years, 5 months ago (2014-07-09 19:55:45 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 20:11:03 UTC) #5
Message was sent while issue was closed.
Change committed as e4636aa17307b00c76e228fc5ddda1bd4904e0dd

Powered by Google App Engine
This is Rietveld 408576698