Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: chrome/android/java/res/layout/menu_item.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/menu_item.xml
diff --git a/chrome/android/java/res/layout/menu_item.xml b/chrome/android/java/res/layout/menu_item.xml
index d917a3a7aea64c748ca8ec367c5e87ced378e981..ed5f48ab20b4edcb35af89e1b2381192a7f5fb1e 100644
--- a/chrome/android/java/res/layout/menu_item.xml
+++ b/chrome/android/java/res/layout/menu_item.xml
@@ -8,6 +8,8 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:paddingStart="?android:attr/listPreferredItemPaddingStart"
+ android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"
android:background="?android:attr/listChoiceBackgroundIndicator">
<TextView
android:id="@+id/menu_item_text"
@@ -18,7 +20,6 @@
android:layout_gravity="start"
android:gravity="center_vertical"
android:singleLine="true"
- android:paddingStart="9dp"
android:paddingEnd="9dp" />
<view
class="org.chromium.chrome.browser.appmenu.AppMenuItemIcon"
@@ -27,6 +28,5 @@
android:layout_width="wrap_content"
android:layout_height="?android:attr/listPreferredItemHeightSmall"
android:layout_gravity="end"
- android:gravity="center_vertical"
- android:paddingEnd="8dp" />
+ android:gravity="center_vertical" />
</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698