chrome/android/java/res/layout/three_button_menu_item.xml - Issue 377083002: Update menu look and feel on Android

Side by Side Diff: chrome/android/java/res/layout/three_button_menu_item.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/four_button_menu_item.xml ('K') | « chrome/android/java/res/layout/menu_item.xml ('k') | chrome/android/java/res/layout/title_button_menu_item.xml » ('j') | chrome/android/java/res/values-v17/styles.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="match_parent"	8 android:layout_width="match_parent"

9 android:layout_height="wrap_content"	9 android:layout_height="wrap_content"

10 android:layout_gravity="top\|start"	10 android:layout_gravity="top\|start"

11 android:orientation="horizontal">	11 android:orientation="horizontal">

12	12

	13 <View

	14 android:layout_width="0dp"

	15 android:layout_height="?android:attr/listPreferredItemHeightSmall"

	16 android:layout_weight="1"

	17 android:background="@null" />

	18

13 <ImageButton	19 <ImageButton

14 android:id="@+id/button_one"	20 android:id="@+id/button_one"

15 android:layout_width="wrap_content"	21 android:layout_width="48dp"
	aurimas (slooooooooow) 2014/07/08 23:49:44 Same question as four_button_menu_item. Why don't Same question as four_button_menu_item. Why don't we use the full width for buttons instead of hardcoding them to 48dp? David Trainor- moved to gerrit 2014/07/09 00:01:56 Not hardcoding to 48dp also will make it difficult Show quoted text On 2014/07/08 23:49:44, aurimas wrote: > Same question as four_button_menu_item. > > Why don't we use the full width for buttons instead of hardcoding them to 48dp? Not hardcoding to 48dp also will make it difficult to line up the menu buttons properly. Also talked to Roma and this seemed like what they want. Thinking about it though, I'm not sure it'd be good to have shrunken hit targets. Worst case I can hard code the padding of the views to make it fit for 260dp...
16 android:layout_height="match_parent"	22 android:layout_height="?android:attr/listPreferredItemHeightSmall"

17 android:layout_weight="1"

18 android:background="?android:attr/listChoiceBackgroundIndicator"	23 android:background="?android:attr/listChoiceBackgroundIndicator"

19 android:scaleType="center" />	24 android:scaleType="center" />

20	25

21 <View	26 <View

22 android:layout_width="1dp"	27 android:layout_width="0dp"

23 android:layout_height="?android:attr/listPreferredItemHeightSmall"	28 android:layout_height="?android:attr/listPreferredItemHeightSmall"

24 android:background="?android:attr/listDivider" />	29 android:layout_weight="1"

	30 android:background="@null" />

25	31

26 <ImageButton	32 <ImageButton

27 android:id="@+id/button_two"	33 android:id="@+id/button_two"

28 android:layout_width="wrap_content"	34 android:layout_width="48dp"

29 android:layout_height="match_parent"	35 android:layout_height="?android:attr/listPreferredItemHeightSmall"

30 android:layout_weight="1"

31 android:background="?android:attr/listChoiceBackgroundIndicator"	36 android:background="?android:attr/listChoiceBackgroundIndicator"

32 android:scaleType="center" />	37 android:scaleType="center" />

33	38

34 <View	39 <View

35 android:layout_width="1dp"	40 android:layout_width="0dp"

36 android:layout_height="?android:attr/listPreferredItemHeightSmall"	41 android:layout_height="?android:attr/listPreferredItemHeightSmall"

37 android:background="?android:attr/listDivider" />	42 android:layout_weight="1"

	43 android:background="@null" />

38	44

39 <ImageButton	45 <ImageButton

40 android:id="@+id/button_three"	46 android:id="@+id/button_three"

41 android:layout_width="wrap_content"	47 android:layout_width="48dp"

42 android:layout_height="match_parent"	48 android:layout_height="?android:attr/listPreferredItemHeightSmall"

43 android:layout_weight="1"

44 android:background="?android:attr/listChoiceBackgroundIndicator"	49 android:background="?android:attr/listChoiceBackgroundIndicator"

45 android:scaleType="center" />	50 android:scaleType="center" />

46	51

	52 <View

	53 android:layout_width="0dp"

	54 android:layout_height="?android:attr/listPreferredItemHeightSmall"

	55 android:layout_weight="1"

	56 android:background="@null" />

47 </LinearLayout>	57 </LinearLayout>

OLD	NEW