Fix memory leak in AsyncExtensionFunction.

Fix memory leak in AsyncExtensionFunction.

BUG=27196
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31517

[Aaron Boodman, 2009-11-09 22:29:48]

http://codereview.chromium.org/377036/diff/3001/3006
File chrome/browser/extensions/extension_function.cc (right):

http://codereview.chromium.org/377036/diff/3001/3006#newcode13
Line 13: args_.reset(args->DeepCopy());
Can we avoid the copy by just having EFD pass ownership of the provided value to
ExtensionFunction?

http://codereview.chromium.org/377036/diff/3001/3007
File chrome/browser/extensions/extension_function.h (right):

http://codereview.chromium.org/377036/diff/3001/3007#newcode130
Line 130: const DictionaryValue* args_as_dict() {
The style guide says to avoid abbreviations. Consider args_as_dictionary()?

[Matt Perry, 2009-11-09 22:34:27]

http://codereview.chromium.org/377036/diff/3001/3006
File chrome/browser/extensions/extension_function.cc (right):

http://codereview.chromium.org/377036/diff/3001/3006#newcode13
Line 13: args_.reset(args->DeepCopy());
On 2009/11/09 22:29:48, Aaron Boodman wrote:
> Can we avoid the copy by just having EFD pass ownership of the provided value
to
> ExtensionFunction?

The value is originally a stack variable, so we can't transfer ownership.

http://codereview.chromium.org/377036/diff/3001/3007
File chrome/browser/extensions/extension_function.h (right):

http://codereview.chromium.org/377036/diff/3001/3007#newcode130
Line 130: const DictionaryValue* args_as_dict() {
On 2009/11/09 22:29:48, Aaron Boodman wrote:
> The style guide says to avoid abbreviations. Consider args_as_dictionary()?

Done.

[Aaron Boodman, 2009-11-09 22:41:44]

LGTM