Fix memory leak in AsyncExtensionFunction.

chrome/browser/extensions/extension_history_api.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_history_api.h"
 
 #include "base/json/json_writer.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/task.h"
@@ skipping 183 matching lines @@
           &HistoryFunctionWithCallback::SendResponseToCallback));
 }
 
 void HistoryFunctionWithCallback::SendResponseToCallback() {
   SendResponse(true);
   Release();  // Balanced in RunImpl().
 }
 
 bool GetVisitsHistoryFunction::RunAsyncImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-  DictionaryValue* json = static_cast<DictionaryValue*>(args_);
+  const DictionaryValue* json = args_as_dictionary();
 
   Value* value;
   EXTENSION_FUNCTION_VALIDATE(json->Get(keys::kUrlKey, &value));
 
   GURL url;
   if (!GetUrlFromValue(value, &url))
     return false;
 
   HistoryService* hs = profile()->GetHistoryService(Profile::EXPLICIT_ACCESS);
   hs->QueryURL(url,
@@ skipping 16 matching lines @@
          ++iterator) {
       AddVisitNode(*iterator, list);
     }
   }
   result_.reset(list);
   SendAsyncResponse();
 }
 
 bool SearchHistoryFunction::RunAsyncImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-  DictionaryValue* json = static_cast<DictionaryValue*>(args_);
+  const DictionaryValue* json = args_as_dictionary();
 
   // Initialize the HistoryQuery
   std::wstring search_text;
   EXTENSION_FUNCTION_VALIDATE(json->GetString(keys::kSearchKey, &search_text));
 
   history::QueryOptions options;
   options.SetRecentDayRange(1);
   options.max_count = 100;
 
   if (json->HasKey(keys::kStartTimeKey)) {  // Optional.
@@ skipping 29 matching lines @@
         ++iterator) {
       AddHistoryNode(**iterator, list);
     }
   }
   result_.reset(list);
   SendAsyncResponse();
 }
 
 bool AddUrlHistoryFunction::RunImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-  DictionaryValue* json = static_cast<DictionaryValue*>(args_);
+  const DictionaryValue* json = args_as_dictionary();
 
   Value* value;
   EXTENSION_FUNCTION_VALIDATE(json->Get(keys::kUrlKey, &value));
 
   GURL url;
   if (!GetUrlFromValue(value, &url))
     return false;
 
   HistoryService* hs = profile()->GetHistoryService(Profile::EXPLICIT_ACCESS);
   hs->AddPage(url);
 
   SendResponse(true);
   return true;
 }
 
 bool DeleteUrlHistoryFunction::RunImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-  DictionaryValue* json = static_cast<DictionaryValue*>(args_);
+  const DictionaryValue* json = args_as_dictionary();
 
   Value* value;
   EXTENSION_FUNCTION_VALIDATE(json->Get(keys::kUrlKey, &value));
 
   GURL url;
   if (!GetUrlFromValue(value, &url))
     return false;
 
   HistoryService* hs = profile()->GetHistoryService(Profile::EXPLICIT_ACCESS);
   hs->DeleteURL(url);
 
   SendResponse(true);
   return true;
 }
 
 bool DeleteRangeHistoryFunction::RunAsyncImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-  DictionaryValue* json = static_cast<DictionaryValue*>(args_);
+  const DictionaryValue* json = args_as_dictionary();
 
   Value* value = NULL;
   EXTENSION_FUNCTION_VALIDATE(json->Get(keys::kStartTimeKey, &value));
   base::Time begin_time;
   EXTENSION_FUNCTION_VALIDATE(GetTimeFromValue(value, &begin_time));
 
   EXTENSION_FUNCTION_VALIDATE(json->Get(keys::kEndTimeKey, &value));
   base::Time end_time;
   EXTENSION_FUNCTION_VALIDATE(GetTimeFromValue(value, &end_time));
 
@@ skipping 18 matching lines @@
       base::Time::Now(),           // To the current time.
       &cancelable_consumer_,
       NewCallback(this, &DeleteAllHistoryFunction::DeleteComplete));
 
   return true;
 }
 
 void DeleteAllHistoryFunction::DeleteComplete() {
   SendAsyncResponse();
 }