Fix memory leak in AsyncExtensionFunction.

chrome/browser/extensions/extension_tabs_module.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tabs_module.h"
 
 #include "app/gfx/codec/jpeg_codec.h"
 #include "base/string_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
@@ skipping 224 matching lines @@
     return false;
   }
   result_.reset(ExtensionTabUtil::CreateWindowValue(browser, false));
   return true;
 }
 
 bool GetAllWindowsFunction::RunImpl() {
   bool populate_tabs = false;
   if (!args_->IsType(Value::TYPE_NULL)) {
     EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-    const DictionaryValue* args = static_cast<const DictionaryValue*>(args_);
+    const DictionaryValue* args = args_as_dictionary();
     if (args->HasKey(keys::kPopulateKey)) {
       EXTENSION_FUNCTION_VALIDATE(args->GetBoolean(keys::kPopulateKey,
           &populate_tabs));
     }
   }
 
   result_.reset(new ListValue());
   for (BrowserList::const_iterator browser = BrowserList::begin();
     browser != BrowserList::end(); ++browser) {
       // Only examine browsers in the current profile.
       if ((*browser)->profile() == profile()) {
         static_cast<ListValue*>(result_.get())->
           Append(ExtensionTabUtil::CreateWindowValue(*browser, populate_tabs));
       }
   }
 
   return true;
 }
 
 bool CreateWindowFunction::RunImpl() {
   scoped_ptr<GURL> url(new GURL());
 
   // Look for optional url.
   if (!args_->IsType(Value::TYPE_NULL)) {
     EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-    const DictionaryValue *args = static_cast<const DictionaryValue*>(args_);
+    const DictionaryValue *args = args_as_dictionary();
     std::string url_input;
     if (args->HasKey(keys::kUrlKey)) {
       EXTENSION_FUNCTION_VALIDATE(args->GetString(keys::kUrlKey,
                                                   &url_input));
       url.reset(new GURL(url_input));
       if (!url->is_valid()) {
         // The path as passed in is not valid. Try converting to absolute path.
         *url = GetExtension()->GetResourceURL(url_input);
         if (!url->is_valid()) {
           error_ = ExtensionErrorUtils::FormatErrorMessage(
@@ skipping 13 matching lines @@
   // be 10)
   //
   // NOTE(rafaelw): It's ok if dispatcher_->GetBrowser() returns NULL here.
   // GetBrowserWindowBounds will default to saved "default" values for the app.
   WindowSizer::GetBrowserWindowBounds(std::wstring(), empty_bounds,
                                       dispatcher()->GetBrowser(), &bounds,
                                       &maximized);
 
   // Any part of the bounds can optionally be set by the caller.
   if (args_->IsType(Value::TYPE_DICTIONARY)) {
-    const DictionaryValue *args = static_cast<const DictionaryValue*>(args_);
+    const DictionaryValue *args = args_as_dictionary();
     int bounds_val;
     if (args->HasKey(keys::kLeftKey)) {
       EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kLeftKey,
                                                    &bounds_val));
       bounds.set_x(bounds_val);
     }
 
     if (args->HasKey(keys::kTopKey)) {
       EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kTopKey,
                                                    &bounds_val));
@@ skipping 22 matching lines @@
 
   // TODO(rafaelw): support |focused|, |zIndex|
 
   result_.reset(ExtensionTabUtil::CreateWindowValue(new_window, false));
 
   return true;
 }
 
 bool UpdateWindowFunction::RunImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_LIST));
-  const ListValue* args = static_cast<const ListValue*>(args_);
+  const ListValue* args = args_as_list();
   int window_id;
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(0, &window_id));
   DictionaryValue* update_props;
   EXTENSION_FUNCTION_VALIDATE(args->GetDictionary(1, &update_props));
 
   Browser* browser = GetBrowserInProfileWithId(profile(), window_id, &error_);
   if (!browser)
     return false;
 
   gfx::Rect bounds = browser->window()->GetRestoredBounds();
@@ skipping 91 matching lines @@
   if (!browser)
     return false;
 
   result_.reset(ExtensionTabUtil::CreateTabList(browser));
 
   return true;
 }
 
 bool CreateTabFunction::RunImpl() {
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
-  const DictionaryValue* args = static_cast<const DictionaryValue*>(args_);
+  const DictionaryValue* args = args_as_dictionary();
 
   Browser *browser;
   // windowId defaults to "current" window.
   int window_id = -1;
   if (args->HasKey(keys::kWindowIdKey)) {
     EXTENSION_FUNCTION_VALIDATE(args->GetInteger(
         keys::kWindowIdKey, &window_id));
     browser = GetBrowserInProfileWithId(profile(), window_id, &error_);
   } else {
     browser = dispatcher()->GetBrowser();
@@ skipping 70 matching lines @@
     return false;
 
   result_.reset(ExtensionTabUtil::CreateTabValue(contents, tab_strip,
       tab_index));
   return true;
 }
 
 bool UpdateTabFunction::RunImpl() {
   int tab_id;
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_LIST));
-  const ListValue* args = static_cast<const ListValue*>(args_);
+  const ListValue* args = args_as_list();
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(0, &tab_id));
   DictionaryValue* update_props;
   EXTENSION_FUNCTION_VALIDATE(args->GetDictionary(1, &update_props));
 
   TabStripModel* tab_strip = NULL;
   TabContents* contents = NULL;
   int tab_index = -1;
   if (!GetTabById(tab_id, profile(), NULL, &tab_strip, &contents, &tab_index,
       &error_))
     return false;
@@ skipping 59 matching lines @@
   if (has_callback())
     result_.reset(ExtensionTabUtil::CreateTabValue(contents, tab_strip,
         tab_index));
 
   return true;
 }
 
 bool MoveTabFunction::RunImpl() {
   int tab_id;
   EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_LIST));
-  const ListValue* args = static_cast<const ListValue*>(args_);
+  const ListValue* args = args_as_list();
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(0, &tab_id));
   DictionaryValue* update_props;
   EXTENSION_FUNCTION_VALIDATE(args->GetDictionary(1, &update_props));
 
   int new_index;
   EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
       keys::kIndexKey, &new_index));
   EXTENSION_FUNCTION_VALIDATE(new_index >= 0);
 
   Browser* source_browser = NULL;
@@ skipping 246 matching lines @@
   if (ExtensionTabUtil::GetTabById(tab_id, profile, browser, tab_strip,
                                    contents, tab_index))
     return true;
 
   if (error_message)
     *error_message = ExtensionErrorUtils::FormatErrorMessage(
         keys::kTabNotFoundError, IntToString(tab_id));
 
   return false;
 }