chrome/browser/extensions/extension_function.cc - Issue 377036: Fix memory leak in AsyncExtensionFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function.cc

Issue 377036: Fix memory leak in AsyncExtensionFunction. (Closed)

Patch Set: feedback Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function.cc

diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc

index b8aaae1cbe2d2ee7421e5f9ca0574976942c28b1..27ce5ebc378348f5a3e541f101f825c7725a3fe2 100644

--- a/chrome/browser/extensions/extension_function.cc

+++ b/chrome/browser/extensions/extension_function.cc

@@ -9,8 +9,8 @@

#include "chrome/browser/extensions/extension_function_dispatcher.h"

void AsyncExtensionFunction::SetArgs(const Value* args) {

- DCHECK(!args_); // Should only be called once.

- args_ = args->DeepCopy();

+ DCHECK(!args_.get()); // Should only be called once.

+ args_.reset(args->DeepCopy());

}

const std::string AsyncExtensionFunction::GetResult() {