Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 374833007: Use reference for paintInvalidationContainer param of invalidatePaintIfNeeded (Closed)

Created:
6 years, 5 months ago by Xianzhu
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Use reference for paintInvalidationContainer param of invalidatePaintIfNeeded BTW also change getPaintInvalidationReason, incrementallyInvalidatePaint and fullyInvalidatePaint which are called only by invalidatePaintIfNeeded. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177694

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M Source/core/rendering/RenderBox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 4 chunks +11 lines, -13 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Xianzhu
https://codereview.chromium.org/374833007/diff/20001/Source/core/rendering/svg/RenderSVGModelObject.cpp File Source/core/rendering/svg/RenderSVGModelObject.cpp (left): https://codereview.chromium.org/374833007/diff/20001/Source/core/rendering/svg/RenderSVGModelObject.cpp#oldcode140 Source/core/rendering/svg/RenderSVGModelObject.cpp:140: ASSERT(paintInvalidationState.paintInvalidationContainer() == containerForPaintInvalidation()); I'm wondering why we are allowing ...
6 years, 5 months ago (2014-07-08 17:53:39 UTC) #1
leviw_travelin_and_unemployed
Sure. LGTM. https://codereview.chromium.org/374833007/diff/20001/Source/core/rendering/svg/RenderSVGModelObject.cpp File Source/core/rendering/svg/RenderSVGModelObject.cpp (left): https://codereview.chromium.org/374833007/diff/20001/Source/core/rendering/svg/RenderSVGModelObject.cpp#oldcode140 Source/core/rendering/svg/RenderSVGModelObject.cpp:140: ASSERT(paintInvalidationState.paintInvalidationContainer() == containerForPaintInvalidation()); On 2014/07/08 17:53:39, Xianzhu ...
6 years, 5 months ago (2014-07-08 18:39:17 UTC) #2
Xianzhu
On 2014/07/08 18:39:17, leviw wrote: > Sure. LGTM. > > https://codereview.chromium.org/374833007/diff/20001/Source/core/rendering/svg/RenderSVGModelObject.cpp > File Source/core/rendering/svg/RenderSVGModelObject.cpp (left): ...
6 years, 5 months ago (2014-07-08 19:24:35 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 5 months ago (2014-07-08 19:24:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/374833007/20001
6 years, 5 months ago (2014-07-08 19:25:03 UTC) #5
commit-bot: I haz the power
Change committed as 177694
6 years, 5 months ago (2014-07-08 20:31:05 UTC) #6
Yuta Kitamura
I'm sorry but I have to revert this change since it depends on r177621 which ...
6 years, 5 months ago (2014-07-09 04:34:58 UTC) #7
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 5 months ago (2014-07-14 23:19:54 UTC) #8
Xianzhu
Rebased on ToT. No more depends on r177621.
6 years, 5 months ago (2014-07-14 23:20:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/374833007/40001
6 years, 5 months ago (2014-07-14 23:20:59 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-15 00:33:43 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 00:40:04 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 00:40:05 UTC) #13
Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

Powered by Google App Engine
This is Rietveld 408576698