Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 374833007: Use reference for paintInvalidationContainer param of invalidatePaintIfNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 843 matching lines...) Expand 10 before | Expand all | Expand 10 after
854 // FIXME: |paintInvalidationContainer| should never be 0. See crbug.com/3636 99. 854 // FIXME: |paintInvalidationContainer| should never be 0. See crbug.com/3636 99.
855 void invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvali dationContainer, const LayoutRect&, InvalidationReason) const; 855 void invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvali dationContainer, const LayoutRect&, InvalidationReason) const;
856 856
857 // Invalidate the paint of the entire object. Called when, e.g., the color o f a border changes, or when a border 857 // Invalidate the paint of the entire object. Called when, e.g., the color o f a border changes, or when a border
858 // style changes. 858 // style changes.
859 void paintInvalidationForWholeRenderer() const; 859 void paintInvalidationForWholeRenderer() const;
860 860
861 // Invalidate the paint of a specific subrectangle within a given object. Th e rect |r| is in the object's coordinate space. 861 // Invalidate the paint of a specific subrectangle within a given object. Th e rect |r| is in the object's coordinate space.
862 void invalidatePaintRectangle(const LayoutRect&) const; 862 void invalidatePaintRectangle(const LayoutRect&) const;
863 863
864 bool invalidatePaintIfNeeded(const RenderLayerModelObject* paintInvalidation Container, 864 bool invalidatePaintIfNeeded(const RenderLayerModelObject& paintInvalidation Container,
865 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer); 865 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer);
866 866
867 // Walk the tree after layout issuing paint invalidations for renderers that have changed or moved, updating bounds that have changed, and clearing paint in validation state. 867 // Walk the tree after layout issuing paint invalidations for renderers that have changed or moved, updating bounds that have changed, and clearing paint in validation state.
868 virtual void invalidateTreeAfterLayout(const RenderLayerModelObject&); 868 virtual void invalidateTreeAfterLayout(const RenderLayerModelObject&);
869 869
870 virtual void invalidatePaintForOverflow(); 870 virtual void invalidatePaintForOverflow();
871 void invalidatePaintForOverflowIfNeeded(); 871 void invalidatePaintForOverflowIfNeeded();
872 872
873 bool checkForPaintInvalidation() const; 873 bool checkForPaintInvalidation() const;
874 874
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
1107 // container, so callers should provide only the offset of the container wit hin it's layer. 1107 // container, so callers should provide only the offset of the container wit hin it's layer.
1108 // containerRect is a rect that has already been added for the currentLayer which is likely to 1108 // containerRect is a rect that has already been added for the currentLayer which is likely to
1109 // be a container for child elements. Any rect wholly contained by container Rect can be 1109 // be a container for child elements. Any rect wholly contained by container Rect can be
1110 // skipped. 1110 // skipped.
1111 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) cons t; 1111 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) cons t;
1112 1112
1113 // Add hit-test rects for this renderer only to the provided list. layerOffs et is the offset 1113 // Add hit-test rects for this renderer only to the provided list. layerOffs et is the offset
1114 // of this renderer within the current layer that should be used for each re sult. 1114 // of this renderer within the current layer that should be used for each re sult.
1115 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const { }; 1115 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const { };
1116 1116
1117 virtual InvalidationReason getPaintInvalidationReason(const RenderLayerModel Object* paintInvalidationContainer, 1117 virtual InvalidationReason getPaintInvalidationReason(const RenderLayerModel Object& paintInvalidationContainer,
1118 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer, 1118 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer,
1119 const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInva lidationContainer); 1119 const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInva lidationContainer);
1120 void incrementallyInvalidatePaint(const RenderLayerModelObject* paintInvalid ationContainer, const LayoutRect& oldBounds, const LayoutRect& newBounds); 1120 void incrementallyInvalidatePaint(const RenderLayerModelObject& paintInvalid ationContainer, const LayoutRect& oldBounds, const LayoutRect& newBounds);
1121 void fullyInvalidatePaint(const RenderLayerModelObject* paintInvalidationCon tainer, InvalidationReason, const LayoutRect& oldBounds, const LayoutRect& newBo unds); 1121 void fullyInvalidatePaint(const RenderLayerModelObject& paintInvalidationCon tainer, InvalidationReason, const LayoutRect& oldBounds, const LayoutRect& newBo unds);
1122 1122
1123 private: 1123 private:
1124 const RenderLayerModelObject* enclosingCompositedContainer() const; 1124 const RenderLayerModelObject* enclosingCompositedContainer() const;
1125 1125
1126 RenderBlock* containerForFixedPosition(const RenderLayerModelObject* paintIn validationContainer = 0, bool* paintInvalidationContainerSkipped = 0) const; 1126 RenderBlock* containerForFixedPosition(const RenderLayerModelObject* paintIn validationContainer = 0, bool* paintInvalidationContainerSkipped = 0) const;
1127 1127
1128 RenderFlowThread* locateFlowThreadContainingBlock() const; 1128 RenderFlowThread* locateFlowThreadContainingBlock() const;
1129 void removeFromRenderFlowThread(); 1129 void removeFromRenderFlowThread();
1130 void removeFromRenderFlowThreadRecursive(RenderFlowThread*); 1130 void removeFromRenderFlowThreadRecursive(RenderFlowThread*);
1131 1131
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 void showTree(const WebCore::RenderObject*); 1532 void showTree(const WebCore::RenderObject*);
1533 void showLineTree(const WebCore::RenderObject*); 1533 void showLineTree(const WebCore::RenderObject*);
1534 void showRenderTree(const WebCore::RenderObject* object1); 1534 void showRenderTree(const WebCore::RenderObject* object1);
1535 // We don't make object2 an optional parameter so that showRenderTree 1535 // We don't make object2 an optional parameter so that showRenderTree
1536 // can be called from gdb easily. 1536 // can be called from gdb easily.
1537 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1537 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1538 1538
1539 #endif 1539 #endif
1540 1540
1541 #endif // RenderObject_h 1541 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698