Use reference for paintInvalidationContainer param of invalidatePaintIfNeeded

Source/core/rendering/svg/RenderSVGModelObject.cpp

 /*
  * Copyright (c) 2009, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
     // FIXME: Should share code with RenderBox::invalidateTreeAfterLayout().
     ASSERT(!needsLayout());
 
     if (!shouldCheckForPaintInvalidationAfterLayout())
         return;
 
     ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState);
 
     const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect();
     const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositionFromPaintInvalidationContainer();
     ASSERT(paintInvalidationState.paintInvalidationContainer() == containerForPaintInvalidation());

[Xianzhu, 2014/07/08 17:53:39]

I'm wondering why we are allowing comparison between a reference and a pointer.

[leviw_travelin_and_unemployed, 2014/07/08 18:39:17]

You're right. That seems wrong. How about fixing it in this CL?

     setPreviousPaintInvalidationRect(boundsRectForPaintInvalidation(&paintInvalidationState.paintInvalidationContainer(), &paintInvalidationState));
     setPreviousPositionFromPaintInvalidationContainer(RenderLayer::positionFromPaintInvalidationContainer(this, &paintInvalidationState.paintInvalidationContainer(), &paintInvalidationState));
 
     // If an ancestor container had its transform changed, then we just
     // need to update the RenderSVGModelObject's repaint rect above. The invalidation
     // will be handled by the container where the transform changed. This essentially
     // means that we prune the entire branch for performance.
     if (!SVGRenderSupport::parentTransformDidChange(this))
         return;
 
     // If we are set to do a full paint invalidation that means the RenderView will be
     // issue paint invalidations. We can then skip issuing of paint invalidations for the child
     // renderers as they'll be covered by the RenderView.
     if (view()->doingFullRepaint()) {
         RenderObject::invalidateTreeAfterLayout(paintInvalidationState);
         return;
     }
 
-    invalidatePaintIfNeeded(containerForPaintInvalidation(), oldPaintInvalidationRect, oldPositionFromPaintInvalidationContainer);
+    invalidatePaintIfNeeded(paintInvalidationState.paintInvalidationContainer(), oldPaintInvalidationRect, oldPositionFromPaintInvalidationContainer);
 
     RenderObject::invalidateTreeAfterLayout(paintInvalidationState);
 }
 
 } // namespace WebCore