Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 309083003: Add macros to define comparison operators to compare by reference or pointer interchangeably (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, blink-reviews-rendering, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, Mikhail, pdr., rune+blink, blink-reviews-wtf_chromium.org, rwlbuis
Visibility:
Public.

Description

Add macros to define comparison operators to compare by reference or pointer interchangeably Add macros to define comparison operators to compare by reference or pointer interchangeably. This avoids redefining them in Node, Frame and RenderObject. There are 2 macros, one for refcounted types and another of non-refcounted ones. R=eseidel@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M Source/core/dom/Node.h View 1 chunk +1 line, -10 lines 0 comments Download
M Source/core/frame/Frame.h View 1 chunk +1 line, -10 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/wtf/Assertions.h View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 6 months ago (2014-06-03 00:11:24 UTC) #1
eseidel
Kinda a odd place to put those macros, but OK. Does Assertions.h know anything about ...
6 years, 6 months ago (2014-06-03 00:33:53 UTC) #2
eseidel
lgtm
6 years, 6 months ago (2014-06-03 00:34:04 UTC) #3
adamk
lgtm
6 years, 6 months ago (2014-06-03 00:52:28 UTC) #4
Inactive
On 2014/06/03 00:33:53, eseidel wrote: > Kinda a odd place to put those macros, but ...
6 years, 6 months ago (2014-06-03 01:48:51 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-03 19:18:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/309083003/1
6 years, 6 months ago (2014-06-03 19:18:47 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:57:51 UTC) #8
Message was sent while issue was closed.
Change committed as 175399

Powered by Google App Engine
This is Rietveld 408576698