Fixes for re-enabling more MSVC level 4 warnings: net/ edition

Fixes for re-enabling more MSVC level 4 warnings: net/ edition

This contains fixes for the following sorts of issues:
* Octal escape sequence terminated by decimal number
* Possibly-uninitialized local variable
* Assignment inside conditional
* Signedness mismatch

This also contains a very small number of other cleanups to nearby code.

BUG=81439
TEST=none
R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281875

[Randy Smith (Not in Mondays), 2014-07-08 19:18:36]

My comment below is a suggestion; you can do with it what you will.  I'm good
with everything but the quic files, but I'm not comfortable stamping a change to
a public interface in a subsystem I'm not familiar with.  Ryan, could you review
the QUIC files?

(I also don't understand where the change comes from; are we ignoring the
results of that function in all call sites?)

https://codereview.chromium.org/374033002/diff/1/net/ftp/ftp_network_transact...
File net/ftp/ftp_network_transaction_unittest.cc (right):

https://codereview.chromium.org/374033002/diff/1/net/ftp/ftp_network_transact...
net/ftp/ftp_network_transaction_unittest.cc:1189: const char response[] = "227
Portscan (\0\0\031" "773\0)\r\n";
Comment to explain the break?  I'm sure without it *someone* will get confused
looking at this code in the future.

[Peter Kasting, 2014-07-08 19:29:18]

On 2014/07/08 19:18:36, rdsmith wrote:
> I'm good
> with everything but the quic files, but I'm not comfortable stamping a change
to
> a public interface in a subsystem I'm not familiar with.  Ryan, could you
review
> the QUIC files?
> 
> (I also don't understand where the change comes from; are we ignoring the
> results of that function in all call sites?)

There are two classes that both define a non-virtual ParseRequestHeaders()
method publicly.  In both cases, the functions are only called at one site, and
that site is within the declaring class; and that one site ignores the function
call result.

One of these was already changed (by someone else) to return void recently, I'm
changing the other.  Really, I think both of these should be made private, but I
was trying to avoid doing too much other cleanup while writing these changes. 
If you guys would like, I'm happy to make both methods private while I'm here.

https://codereview.chromium.org/374033002/diff/1/net/ftp/ftp_network_transact...
File net/ftp/ftp_network_transaction_unittest.cc (right):

https://codereview.chromium.org/374033002/diff/1/net/ftp/ftp_network_transact...
net/ftp/ftp_network_transaction_unittest.cc:1189: const char response[] = "227
Portscan (\0\0\031" "773\0)\r\n";
On 2014/07/08 19:18:35, rdsmith wrote:
> Comment to explain the break?  I'm sure without it *someone* will get confused
> looking at this code in the future.

Done.

[Ryan Hamilton, 2014-07-08 19:50:25]

Changes to net/tools/quic LGTM. These files will hopefully be deleted in the
next couple of weeks so it's not terribly important to make them private.

[Peter Kasting, 2014-07-08 19:53:29]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-07-08 19:55:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/374033002/20001

[commit-bot: I haz the power, 2014-07-08 22:26:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-07-08 22:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 22:28:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Peter Kasting, 2014-07-08 23:23:18]

Committed patchset #2 manually as r281875 (presubmit successful).