net/disk_cache/blockfile/entry_impl.cc - Issue 374033002: Fixes for re-enabling more MSVC level 4 warnings: net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/entry_impl.cc

Issue 374033002: Fixes for re-enabling more MSVC level 4 warnings: net/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/entry_impl.cc

diff --git a/net/disk_cache/blockfile/entry_impl.cc b/net/disk_cache/blockfile/entry_impl.cc

index 6ff52358485dfb82abf5bb46456311734cded7c8..3c3b218342df0eae8c389102cc436ba3eccf25d3 100644

--- a/net/disk_cache/blockfile/entry_impl.cc

+++ b/net/disk_cache/blockfile/entry_impl.cc

@@ -942,7 +942,8 @@ EntryImpl::~EntryImpl() {

bool ret = true;

for (int index = 0; index < kNumStreams; index++) {

if (user_buffers_[index].get()) {

- if (!(ret = Flush(index, 0)))

+ ret = Flush(index, 0);

+ if (!ret)

LOG(ERROR) << "Failed to save user data";

}

if (unreported_size_[index]) {

« no previous file with comments | « net/cert/test_root_certs_win.cc ('k') | net/dns/host_resolver.h » ('j') | no next file with comments »