Fixes for re-enabling more MSVC level 4 warnings: net/ edition

net/tools/quic/quic_spdy_server_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/quic_spdy_server_stream.h"
 
 #include "base/memory/singleton.h"
 #include "net/quic/quic_session.h"
 #include "net/spdy/spdy_framer.h"
 #include "net/tools/quic/quic_in_memory_cache.h"
@@ skipping 46 matching lines @@
     SendErrorResponse();  // We're not done reading headers.
   } else if ((headers_.content_length_status() ==
               BalsaHeadersEnums::VALID_CONTENT_LENGTH) &&
              body_.size() != headers_.content_length()) {
     SendErrorResponse();  // Invalid content length
   } else {
     SendResponse();
   }
 }
 
-int QuicSpdyServerStream::ParseRequestHeaders() {
+void QuicSpdyServerStream::ParseRequestHeaders() {
   size_t read_buf_len = static_cast<size_t>(read_buf_->offset());
   SpdyFramer framer(SPDY3);
   SpdyHeaderBlock headers;
   char* data = read_buf_->StartOfBuffer();
   size_t len = framer.ParseHeaderBlockInBuffer(data, read_buf_->offset(),
                                                &headers);
   if (len == 0) {
-    return -1;
+    return;
   }
 
   if (!SpdyUtils::FillBalsaRequestHeaders(headers, &headers_)) {
     SendErrorResponse();
-    return -1;
+    return;
   }
 
   size_t delta = read_buf_len - len;
   if (delta > 0) {
     body_.append(data + len, delta);
   }
 
   request_headers_received_ = true;
-  return len;
 }
 
 void QuicSpdyServerStream::SendResponse() {
   // Find response in cache. If not found, send error response.
   const QuicInMemoryCache::Response* response =
       QuicInMemoryCache::GetInstance()->GetResponse(headers_);
   if (response == NULL) {
     SendErrorResponse();
     return;
   }
@@ skipping 35 matching lines @@
 
   WriteHeaders(header_block, body.empty(), NULL);
 
   if (!body.empty()) {
     WriteOrBufferData(body, true, NULL);
   }
 }
 
 }  // namespace tools
 }  // namespace net