Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: net/tools/quic/quic_spdy_server_stream.cc

Issue 374033002: Fixes for re-enabling more MSVC level 4 warnings: net/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_spdy_server_stream.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_server_stream.cc
diff --git a/net/tools/quic/quic_spdy_server_stream.cc b/net/tools/quic/quic_spdy_server_stream.cc
index 7ae20d02e97eb1376acc87035353fcc0e41acda9..ab861fd0d61f90d381b29c8ade28c1549f068107 100644
--- a/net/tools/quic/quic_spdy_server_stream.cc
+++ b/net/tools/quic/quic_spdy_server_stream.cc
@@ -64,7 +64,7 @@ void QuicSpdyServerStream::OnFinRead() {
}
}
-int QuicSpdyServerStream::ParseRequestHeaders() {
+void QuicSpdyServerStream::ParseRequestHeaders() {
size_t read_buf_len = static_cast<size_t>(read_buf_->offset());
SpdyFramer framer(SPDY3);
SpdyHeaderBlock headers;
@@ -72,12 +72,12 @@ int QuicSpdyServerStream::ParseRequestHeaders() {
size_t len = framer.ParseHeaderBlockInBuffer(data, read_buf_->offset(),
&headers);
if (len == 0) {
- return -1;
+ return;
}
if (!SpdyUtils::FillBalsaRequestHeaders(headers, &headers_)) {
SendErrorResponse();
- return -1;
+ return;
}
size_t delta = read_buf_len - len;
@@ -86,7 +86,6 @@ int QuicSpdyServerStream::ParseRequestHeaders() {
}
request_headers_received_ = true;
- return len;
}
void QuicSpdyServerStream::SendResponse() {
« no previous file with comments | « net/tools/quic/quic_spdy_server_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698