Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 372773002: Remove use of GrEffectRef from draw state and below. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove use of GrEffectRef from draw state and below. Committed: https://skia.googlesource.com/skia/+/f99f884cd82528684779e40413f1ceaf277dad2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -50 lines) Patch
M include/gpu/GrDrawEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrEffectStage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPaint.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
After this change we will grab the GrEffect out of the GrEffectRef when an effect ...
6 years, 5 months ago (2014-07-07 18:30:44 UTC) #1
robertphillips
lgtm
6 years, 5 months ago (2014-07-07 18:35:10 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-07 18:37:39 UTC) #3
bsalomon
On 2014/07/07 18:30:44, bsalomon wrote: > After this change we will grab the GrEffect out ...
6 years, 5 months ago (2014-07-07 18:38:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/372773002/1
6 years, 5 months ago (2014-07-07 18:38:48 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 18:54:28 UTC) #6
Message was sent while issue was closed.
Change committed as f99f884cd82528684779e40413f1ceaf277dad2d

Powered by Google App Engine
This is Rietveld 408576698