Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 372053003: Revert of Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@no_ref
Visibility:
Public.

Description

Revert of Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. (https://codereview.chromium.org/377503004/) Reason for revert: broke linux builders Original issue's description: > Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. > > Make Sk-effect virtuals produce GrEffect* rather than GrEffectRef* > > Make GrEffectRef a typedef for GrEffect. > > Committed: https://skia.googlesource.com/skia/+/2011fe9cdfa63b83489a146cea6a724cede352c8 TBR=robertphillips@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/969842ac9c3825100c86c8dae88d931c06286622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -139 lines) Patch
M include/core/SkColorFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkColorShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkImageFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkShader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkXfermode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrBackendEffectFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrEffect.h View 8 chunks +137 lines, -27 lines 0 comments Download
M include/gpu/GrEffectStage.h View 6 chunks +14 lines, -14 lines 0 comments Download
M include/gpu/GrEffectUnitTest.h View 3 chunks +17 lines, -17 lines 0 comments Download
M include/gpu/GrPaint.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 2 chunks +10 lines, -6 lines 0 comments Download
M src/gpu/GrEffect.cpp View 1 chunk +19 lines, -1 line 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
Created Revert of Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*.
6 years, 5 months ago (2014-07-07 22:16:41 UTC) #1
reed1
On 2014/07/07 22:16:41, reed1 wrote: > Created Revert of Make GrDrawState and GrPaint take GrEffect* ...
6 years, 5 months ago (2014-07-07 22:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/372053003/1
6 years, 5 months ago (2014-07-07 22:17:27 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 22:17:54 UTC) #4
Message was sent while issue was closed.
Change committed as 969842ac9c3825100c86c8dae88d931c06286622

Powered by Google App Engine
This is Rietveld 408576698