Revert 281304 "Pass an instance of FaviconClient to FaviconService."

Revert 281304 "Pass an instance of FaviconClient to FaviconService."

Broke the Linux ASan LSan Test(2) bot

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5ac35b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x1df3a96 in (anonymous namespace)::BuildFaviconService(content::BrowserContext*) chrome/browser/favicon/favicon_handler_unittest.cc:1408
    #2 0xf2c3cc0 in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:88
    #3 0x549067a in FaviconServiceFactory::GetForProfile(Profile*, Profile::ServiceAccessType) chrome/browser/favicon/favicon_service_factory.cc:25
    #4 0x1df00f4 in (anonymous namespace)::FaviconHandlerTest_UnableToDownloadFavicon_Test::TestBody() chrome/browser/favicon/favicon_handler_unittest.cc:1432
    #5 0x6cc96f8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #6 0x6cc96f8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #7 0x6ccbed9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #8 0x6cccc66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #9 0x6cdfd7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #10 0x6cdf3b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #11 0x6cdf3b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #12 0x1021320c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #13 0x1021320c in base::TestSuite::Run() base/test/test_suite.cc:227
    #14 0x1020a9d2 in Run base/callback.h:401
    #15 0x1020a9d2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
    #16 0x1020a34d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553
    #17 0x6df1bee in main chrome/test/base/run_all_unittests.cc:15
    #18 0x7f93160dc76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


> Pass an instance of FaviconClient to FaviconService.
> 
> This is an intermediary CL where the FaviconClient is not used by the FaviconService.
> Subsequent CLs will start using the FaviconClient in the FaviconService to abstract usage of chrome/ code.
> 
> BUG=377505
> 
> Review URL: https://codereview.chromium.org/302433010

TBR=jif@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281309

[csharp, 2014-07-03 19:26:43]

Committed patchset #1 manually as r281309 (tree was closed).