Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: trunk/src/chrome/browser/favicon/favicon_service_factory.cc

Issue 370663002: Revert 281304 "Pass an instance of FaviconClient to FaviconService." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/favicon/favicon_service_factory.h" 5 #include "chrome/browser/favicon/favicon_service_factory.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/favicon/chrome_favicon_client_factory.h"
10 #include "chrome/browser/favicon/favicon_service.h" 9 #include "chrome/browser/favicon/favicon_service.h"
11 #include "chrome/browser/history/history_service.h" 10 #include "chrome/browser/history/history_service.h"
12 #include "chrome/browser/history/history_service_factory.h" 11 #include "chrome/browser/history/history_service_factory.h"
13 #include "chrome/common/pref_names.h" 12 #include "chrome/common/pref_names.h"
14 #include "components/keyed_service/content/browser_context_dependency_manager.h" 13 #include "components/keyed_service/content/browser_context_dependency_manager.h"
15 14
16 // static 15 // static
17 FaviconService* FaviconServiceFactory::GetForProfile( 16 FaviconService* FaviconServiceFactory::GetForProfile(
18 Profile* profile, Profile::ServiceAccessType sat) { 17 Profile* profile, Profile::ServiceAccessType sat) {
19 if (!profile->IsOffTheRecord()) { 18 if (!profile->IsOffTheRecord()) {
(...skipping 14 matching lines...) Expand all
34 // static 33 // static
35 FaviconServiceFactory* FaviconServiceFactory::GetInstance() { 34 FaviconServiceFactory* FaviconServiceFactory::GetInstance() {
36 return Singleton<FaviconServiceFactory>::get(); 35 return Singleton<FaviconServiceFactory>::get();
37 } 36 }
38 37
39 FaviconServiceFactory::FaviconServiceFactory() 38 FaviconServiceFactory::FaviconServiceFactory()
40 : BrowserContextKeyedServiceFactory( 39 : BrowserContextKeyedServiceFactory(
41 "FaviconService", 40 "FaviconService",
42 BrowserContextDependencyManager::GetInstance()) { 41 BrowserContextDependencyManager::GetInstance()) {
43 DependsOn(HistoryServiceFactory::GetInstance()); 42 DependsOn(HistoryServiceFactory::GetInstance());
44 DependsOn(ChromeFaviconClientFactory::GetInstance());
45 } 43 }
46 44
47 FaviconServiceFactory::~FaviconServiceFactory() {} 45 FaviconServiceFactory::~FaviconServiceFactory() {}
48 46
49 KeyedService* FaviconServiceFactory::BuildServiceInstanceFor( 47 KeyedService* FaviconServiceFactory::BuildServiceInstanceFor(
50 content::BrowserContext* profile) const { 48 content::BrowserContext* profile) const {
51 FaviconClient* favicon_client = 49 return new FaviconService(static_cast<Profile*>(profile));
52 ChromeFaviconClientFactory::GetForProfile(static_cast<Profile*>(profile));
53 return new FaviconService(static_cast<Profile*>(profile), favicon_client);
54 } 50 }
55 51
56 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const { 52 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {
57 return true; 53 return true;
58 } 54 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698