Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: trunk/src/chrome/browser/history/android/sqlite_cursor_unittest.cc

Issue 370663002: Revert 281304 "Pass an instance of FaviconClient to FaviconService." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/history/android/sqlite_cursor_unittest.cc
===================================================================
--- trunk/src/chrome/browser/history/android/sqlite_cursor_unittest.cc (revision 281307)
+++ trunk/src/chrome/browser/history/android/sqlite_cursor_unittest.cc (working copy)
@@ -12,8 +12,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/browser/favicon/chrome_favicon_client.h"
-#include "chrome/browser/favicon/chrome_favicon_client_factory.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/history/android/android_history_provider_service.h"
#include "chrome/browser/history/android/android_history_types.h"
@@ -200,10 +198,7 @@
column_names.push_back(HistoryAndBookmarkRow::GetAndroidName(
HistoryAndBookmarkRow::FAVICON));
- FaviconClient* favicon_client =
- ChromeFaviconClientFactory::GetForProfile(testing_profile_);
- FaviconService* favicon_service =
- new FaviconService(testing_profile_, favicon_client);
+ FaviconService* favicon_service = new FaviconService(testing_profile_);
SQLiteCursor* cursor = new SQLiteCursor(column_names, statement,
service_.get(), favicon_service);
« no previous file with comments | « trunk/src/chrome/browser/favicon/favicon_service_factory.cc ('k') | trunk/src/chrome/test/base/testing_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698