Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: trunk/src/chrome/browser/favicon/favicon_service.h

Issue 370663002: Revert 281304 "Pass an instance of FaviconClient to FaviconService." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/favicon/favicon_service.h
===================================================================
--- trunk/src/chrome/browser/favicon/favicon_service.h (revision 281307)
+++ trunk/src/chrome/browser/favicon/favicon_service.h (working copy)
@@ -15,7 +15,6 @@
#include "components/favicon_base/favicon_types.h"
#include "components/keyed_service/core/keyed_service.h"
-class FaviconClient;
class GURL;
class HistoryService;
struct ImportedFaviconUsage;
@@ -25,9 +24,7 @@
// backend behind the scenes.
class FaviconService : public KeyedService {
public:
- // TODO(jif): Remove usage of Profile. http://crbug.com/378208.
- // The FaviconClient must outlive the constructed FaviconService.
- FaviconService(Profile* profile, FaviconClient* favicon_client);
+ explicit FaviconService(Profile* profile);
virtual ~FaviconService();
@@ -222,7 +219,6 @@
base::hash_set<MissingFaviconURLHash> missing_favicon_urls_;
HistoryService* history_service_;
Profile* profile_;
- FaviconClient* favicon_client_;
// Helper function for GetFaviconImageForPageURL(), GetRawFaviconForPageURL()
// and GetFaviconForPageURL().
« no previous file with comments | « trunk/src/chrome/browser/favicon/favicon_handler_unittest.cc ('k') | trunk/src/chrome/browser/favicon/favicon_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698