Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 368313005: IDL: Add support for [TreatNullAs=EmptyString] (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Add support for [TreatNullAs=EmptyString] [TreatNullAs=NullString] was already supported, and still is, but is non-standard. [TreatNullAs=EmptyString] is what Web IDL has and what is used in specifications to describe required behavior. There are cases where web-exposed behavior relating to handling of null is wrong today, and where using [TreatNullAs=EmptyString] instead would be the natural fix. BUG=391194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177561

Patch Set 1 #

Patch Set 2 : fix debug compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -36 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8StringResource.h View 1 4 chunks +33 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8HistoryCustom.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 12 chunks +60 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Jens Widell
PTAL Step one in the plan outlined in bug 391194.
6 years, 5 months ago (2014-07-04 08:57:31 UTC) #1
haraken
On 2014/07/04 08:57:31, Jens Lindström wrote: > PTAL > > Step one in the plan ...
6 years, 5 months ago (2014-07-04 10:42:53 UTC) #2
Jens Widell
On 2014/07/04 10:42:53, haraken wrote: > On 2014/07/04 08:57:31, Jens Lindström wrote: > > PTAL ...
6 years, 5 months ago (2014-07-04 11:11:49 UTC) #3
haraken
On 2014/07/04 11:11:49, Jens Lindström wrote: > On 2014/07/04 10:42:53, haraken wrote: > > On ...
6 years, 5 months ago (2014-07-04 14:37:48 UTC) #4
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-04 14:45:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/368313005/1
6 years, 5 months ago (2014-07-04 14:46:39 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-04 15:29:38 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-04 15:36:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/11455)
6 years, 5 months ago (2014-07-04 15:36:54 UTC) #9
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-05 07:55:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/368313005/20001
6 years, 5 months ago (2014-07-05 07:56:24 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-05 09:01:06 UTC) #12
Message was sent while issue was closed.
Change committed as 177561

Powered by Google App Engine
This is Rietveld 408576698