Source/bindings/core/v8/V8Binding.cpp - Issue 368313005: IDL: Add support for [TreatNullAs=EmptyString]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 368313005: IDL: Add support for [TreatNullAs=EmptyString] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix debug compilation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8Binding.cpp

diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp

index 946677479d7a7d0db34fdb0ba61249c62409f7eb..ebbaba46261f5e6b2fe28f8b8f9cb43ac5c38cc7 100644

--- a/Source/bindings/core/v8/V8Binding.cpp

+++ b/Source/bindings/core/v8/V8Binding.cpp

@@ -883,7 +883,7 @@ PassRefPtr<JSONValue> v8ToJSONValue(v8::Isolate* isolate, v8::Handle<v8::Value>

RefPtr<JSONValue> propertyValue = v8ToJSONValue(isolate, object->Get(name), maxDepth);

if (!propertyValue)

return nullptr;

- TOSTRING_DEFAULT(V8StringResource<WithNullCheck>, nameString, name, nullptr);

+ TOSTRING_DEFAULT(V8StringResource<TreatNullAsNullString>, nameString, name, nullptr);

jsonObject->setValue(nameString, propertyValue);

}

return jsonObject;