Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: Source/bindings/core/v8/custom/V8HistoryCustom.cpp

Issue 368313005: IDL: Add support for [TreatNullAs=EmptyString] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix debug compilation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8HistoryCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HistoryCustom.cpp b/Source/bindings/core/v8/custom/V8HistoryCustom.cpp
index 693eb3bef01dc0f82fdedb46b22329eb95de0c62..427598bc3e51b4dad02154e142892777e081718f 100644
--- a/Source/bindings/core/v8/custom/V8HistoryCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8HistoryCustom.cpp
@@ -66,8 +66,8 @@ void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
if (exceptionState.throwIfNeeded())
return;
- TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
- TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, info[2]);
+ TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, title, info[1]);
+ TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, url, info[2]);
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, FrameLoadTypeStandard, exceptionState);
@@ -82,8 +82,8 @@ void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Valu
if (exceptionState.throwIfNeeded())
return;
- TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
- TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, info[2]);
+ TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, title, info[1]);
+ TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, url, info[2]);
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, FrameLoadTypeRedirectWithLockedBackForwardList, exceptionState);

Powered by Google App Engine
This is Rietveld 408576698