Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 368313005: IDL: Add support for [TreatNullAs=EmptyString]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 368313005: IDL: Add support for [TreatNullAs=EmptyString] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix debug compilation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

index faec5deee6a7d378c5a47dc52c8d82c56d04b81f..750e53538b7b7f0d48da1a96e1a16f4a56697e47 100644

--- a/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -219,7 +219,7 @@ void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name

if (!propInfo)

return;

- TOSTRING_VOID(V8StringResource<WithNullCheck>, propertyValue, value);

+ TOSTRING_VOID(V8StringResource<TreatNullAsNullString>, propertyValue, value);

ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName(static_cast<CSSPropertyID>(propInfo->propID)), "CSSStyleDeclaration", info.Holder(), info.GetIsolate());

impl->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), propertyValue, false, exceptionState);

« no previous file with comments | « Source/bindings/core/v8/V8StringResource.h ('k') | Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp » ('j') | no next file with comments »