Issue 3654001: Revert 61899 for breaking cookes on file:// URLs....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3654001: Revert 61899 for breaking cookes on file:// URLs.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 5 months ago by willchan

Modified:
2 years, 9 months ago

Reviewers:
willchan

CC:
chromium-reviews_chromium.org, Victoria Kirst, fbarchard, Alpha, Sergey Ulanov, ben+cc_chromium.org, jam, dmac, darin-cc_chromium.org, awong, garykac, Paweł Hajdan Jr., brettw-cc_chromium.org, scherkus (OOO Mar 12-14)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

    Revert 61899 for breaking cookes on file:// URLs.
BUG=58553
=================================================
Fix instances of passing raw pointers to RefCounted objects in tasks.

Some of these manually handled it correctly by using AddRef()/Release() pairs.  I switched them to make_scoped_refptr() to be more consistent.  This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/3581008

TBR=willchan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62043
  

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -158 lines)			Patch
M	chrome/browser/automation/automation_resource_message_filter.cc	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_file_manager.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/download/download_manager.cc	View	4 chunks	+7 lines, -18 lines	0 comments	Download
M	chrome/browser/download/save_file_manager.cc	View	2 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/download/save_package.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/importer/importer_unittest.cc	View	2 chunks	+8 lines, -20 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc	View	1 chunk	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/audio_renderer_host.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/save_file_resource_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/profile_import/profile_import_thread.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/profile_import/profile_import_thread.cc	View	5 chunks	+7 lines, -12 lines	0 comments	Download
M	chrome/service/service_process.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	ipc/ipc_channel_proxy.cc	View	2 chunks	+10 lines, -11 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	media/filters/decoder_base.h	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	media/filters/omx_video_decoder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/host_key_pair.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Trybot results:

Messages

Total messages: 1

Expand All Messages | Collapse All Messages