Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 3654001: Revert 61899 for breaking cookes on file:// URLs.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by willchan
Modified:
2 years, 11 months ago
Reviewers:
willchan
CC:
chromium-reviews_chromium.org, Victoria Kirst, fbarchard, Alpha, Sergey Ulanov, ben+cc_chromium.org, jam, dmac, darin-cc_chromium.org, awong, garykac, PaweĊ‚ Hajdan Jr., brettw-cc_chromium.org, scherkus
Visibility:
Public.

Description

Revert 61899 for breaking cookes on file:// URLs.
BUG=58553
=================================================
Fix instances of passing raw pointers to RefCounted objects in tasks.

Some of these manually handled it correctly by using AddRef()/Release() pairs. I switched them to make_scoped_refptr() to be more consistent. This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/3581008

TBR=willchan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -158 lines) Lint Patch
M chrome/browser/automation/automation_resource_message_filter.cc View 2 chunks +2 lines, -9 lines 0 comments 0 errors Download
M chrome/browser/debugger/devtools_http_protocol_handler.cc View 4 chunks +4 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/download/download_file_manager.cc View 1 chunk +3 lines, -7 lines 0 comments 0 errors Download
M chrome/browser/download/download_manager.cc View 4 chunks +7 lines, -18 lines 0 comments 0 errors Download
M chrome/browser/download/save_file_manager.cc View 2 chunks +9 lines, -10 lines 0 comments 0 errors Download
M chrome/browser/download/save_package.cc View 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M chrome/browser/importer/importer_unittest.cc View 2 chunks +8 lines, -20 lines 0 comments 0 errors Download
M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc View 1 chunk +3 lines, -11 lines 0 comments 0 errors Download
M chrome/browser/notifications/desktop_notification_service_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/audio_renderer_host.cc View 5 chunks +5 lines, -5 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/save_file_resource_handler.cc View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +6 lines, -5 lines 0 comments 0 errors Download
M chrome/profile_import/profile_import_thread.h View 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M chrome/profile_import/profile_import_thread.cc View 5 chunks +7 lines, -12 lines 0 comments 0 errors Download
M chrome/service/service_process.cc View 1 chunk +2 lines, -6 lines 0 comments 0 errors Download
M ipc/ipc_channel_proxy.cc View 2 chunks +10 lines, -11 lines 0 comments 0 errors Download
M media/base/pipeline_impl.cc View 1 chunk +2 lines, -6 lines 0 comments 0 errors Download
M media/filters/decoder_base.h View 1 chunk +4 lines, -9 lines 0 comments 0 errors Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +2 lines, -5 lines 0 comments 0 errors Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +5 lines, -6 lines 0 comments 0 errors Download
M media/filters/omx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M remoting/host/host_key_pair.cc View 1 chunk +1 line, -3 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 1
willchan
3 years, 6 months ago #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6