Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 3654001: Revert 61899 for breaking cookes on file:// URLs.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_service.cc (revision 62042)
+++ chrome/browser/safe_browsing/safe_browsing_service.cc (working copy)
@@ -386,6 +386,9 @@
mackey_url_prefix,
disable_auto_update);
+ // Balance the reference added by Start().
+ request_context_getter->Release();
+
protocol_manager_->Initialize();
}
@@ -645,16 +648,14 @@
}
// We will issue network fetches using the default profile's request context.
- scoped_refptr<URLRequestContextGetter> request_context_getter =
+ URLRequestContextGetter* request_context_getter =
GetDefaultProfile()->GetRequestContext();
+ request_context_getter->AddRef(); // Balanced in OnIOInitialize.
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
NewRunnableMethod(
- this,
- &SafeBrowsingService::OnIOInitialize,
- client_key,
- wrapped_key,
+ this, &SafeBrowsingService::OnIOInitialize, client_key, wrapped_key,
request_context_getter));
}
« no previous file with comments | « chrome/browser/renderer_host/save_file_resource_handler.cc ('k') | chrome/profile_import/profile_import_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698