Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/download/download_manager.cc

Issue 3654001: Revert 61899 for breaking cookes on file:// URLs.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_file_manager.cc ('k') | chrome/browser/download/save_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager.cc
===================================================================
--- chrome/browser/download/download_manager.cc (revision 62042)
+++ chrome/browser/download/download_manager.cc (working copy)
@@ -76,7 +76,7 @@
ChromeThread::PostTask(ChromeThread::FILE, FROM_HERE,
NewRunnableMethod(file_manager_,
&DownloadFileManager::OnDownloadManagerShutdown,
- make_scoped_refptr(this)));
+ this));
}
// 'in_progress_' may contain DownloadItems that have not finished the start
@@ -437,12 +437,8 @@
ChromeThread::PostTask(
ChromeThread::FILE, FROM_HERE,
NewRunnableMethod(
- file_manager_,
- &DownloadFileManager::OnFinalDownloadName,
- download->id(),
- target_path,
- !info->is_dangerous,
- make_scoped_refptr(this)));
+ file_manager_, &DownloadFileManager::OnFinalDownloadName,
+ download->id(), target_path, !info->is_dangerous, this));
} else {
// The download hasn't finished and it is a safe download. We need to
// rename it to its intermediate '.crdownload' path.
@@ -450,11 +446,8 @@
ChromeThread::PostTask(
ChromeThread::FILE, FROM_HERE,
NewRunnableMethod(
- file_manager_,
- &DownloadFileManager::OnIntermediateDownloadName,
- download->id(),
- download_path,
- make_scoped_refptr(this)));
+ file_manager_, &DownloadFileManager::OnIntermediateDownloadName,
+ download->id(), download_path, this));
download->set_need_final_rename(true);
}
@@ -539,12 +532,8 @@
ChromeThread::PostTask(
ChromeThread::FILE, FROM_HERE,
NewRunnableMethod(
- file_manager_,
- &DownloadFileManager::OnFinalDownloadName,
- download->id(),
- download->full_path(),
- false,
- make_scoped_refptr(this)));
+ file_manager_, &DownloadFileManager::OnFinalDownloadName,
+ download->id(), download->full_path(), false, this));
return;
}
« no previous file with comments | « chrome/browser/download/download_file_manager.cc ('k') | chrome/browser/download/save_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698