Revert 61899 for breaking cookes on file:// URLs....

chrome/browser/download/save_file_manager.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/download/save_file_manager.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 113 matching lines @@
                               URLRequestContextGetter* request_context_getter,
                               SavePackage* save_package) {
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
 
   // Register a saving job.
   RegisterStartingRequest(url, save_package);
   if (save_source == SaveFileCreateInfo::SAVE_FILE_FROM_NET) {
     DCHECK(url.is_valid());
 
     ChromeThread::PostTask(
-        ChromeThread::IO,
-        FROM_HERE,
-        NewRunnableMethod(
-            this,
-            &SaveFileManager::OnSaveURL,
-            url,
-            referrer,
-            render_process_host_id,
-            render_view_id,
-            make_scoped_refptr(request_context_getter)));
+        ChromeThread::IO, FROM_HERE,
+        NewRunnableMethod(this,
+                          &SaveFileManager::OnSaveURL,
+                          url,
+                          referrer,
+                          render_process_host_id,
+                          render_view_id,
+                          request_context_getter));
   } else {
     // We manually start the save job.
     SaveFileCreateInfo* info = new SaveFileCreateInfo(file_full_path,
          url,
          save_source,
          -1);
     info->render_process_id = render_process_host_id;
     info->render_view_id = render_view_id;
 
     // Since the data will come from render process, so we need to start
@@ skipping 91 matching lines @@
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE));
   SaveFile* save_file = LookupSaveFile(save_id);
   if (save_file) {
     bool write_success = save_file->AppendDataToFile(data->data(), data_len);
     ChromeThread::PostTask(
       ChromeThread::UI, FROM_HERE,
         NewRunnableMethod(
             this, &SaveFileManager::OnUpdateSaveProgress, save_file->save_id(),
             save_file->bytes_so_far(), write_success));
   }
+  data->Release();
 }
 
 // The IO thread will call this when saving is completed or it got error when
 // fetching data. In the former case, we forward the message to OnSaveFinished
 // in UI thread. In the latter case, the save ID will be -1, which means the
 // saving action did not even start, so we need to call OnErrorFinished in UI
 // thread, which will use the save URL to find corresponding request record and
 // delete it.
 void SaveFileManager::SaveFinished(int save_id,
                                    GURL save_url,
@@ skipping 260 matching lines @@
     SaveFileMap::iterator it = save_file_map_.find(*i);
     if (it != save_file_map_.end()) {
       SaveFile* save_file = it->second;
       DCHECK(!save_file->in_progress());
       file_util::Delete(save_file->full_path(), false);
       delete save_file;
       save_file_map_.erase(it);
     }
   }
 }