Issue 361113002: Properly managing overlfow-aligment for inherit and initial.

Issue 361113002: Properly managing overlfow-aligment for inherit and initial. (Closed)

Created:
6 years, 5 months ago by jfernandez

Modified:
6 years, 5 months ago

Reviewers:
Timothy Loh, Julien - ping for review, ojan

CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Properly managing overlfow-aligment for inherit and initial. The CSS3 Alignment properties allow pairs as values; that's the case of overflow-aligment and "legacy" keyword. The StyleBulder should define custom "initial" and "inherit" handers to properly managing such values. BUG=249451, 376823 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177384

Patch Set 1 #

Total comments: 2

Patch Set 2 : Applied suggested changes. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -61 lines)			Patch
M	LayoutTests/fast/alignment/parse-justify-items.html	View		1 chunk	+9 lines, -20 lines	0 comments	Download
M	LayoutTests/fast/alignment/parse-justify-items-expected.txt	View		2 chunks	+22 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/alignment/resources/alignment-parsing-utils.js	View		1 chunk	+36 lines, -12 lines	0 comments	Download
M	Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl	View	1	2 chunks	+13 lines, -19 lines	0 comments	Download
M	Source/core/css/CSSProperties.in	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Timothy Loh

Thanks for doing this, lgtm https://codereview.chromium.org/361113002/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl File Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl (right): https://codereview.chromium.org/361113002/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl#newcode563 Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl:563: {{declare_inherit_function(property_id)}} Looks like the ...

6 years, 5 months ago (2014-07-02 01:20:02 UTC) #2

jfernandez

Done, thanks for review. https://codereview.chromium.org/361113002/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl File Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl (right): https://codereview.chromium.org/361113002/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl#newcode563 Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl:563: {{declare_inherit_function(property_id)}} On 2014/07/02 01:20:02, Timothy ...

6 years, 5 months ago (2014-07-02 10:10:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfernandez@igalia.com/361113002/20001

6 years, 5 months ago (2014-07-02 10:11:43 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...

6 years, 5 months ago (2014-07-02 11:17:58 UTC) #6

Message was sent while issue was closed.

Change committed as 177384

Expand Messages | Collapse Messages