Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: LayoutTests/fast/alignment/parse-justify-items.html

Issue 361113002: Properly managing overlfow-aligment for inherit and initial. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Applied suggested changes. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/alignment/parse-justify-items-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/alignment/parse-justify-items.html
diff --git a/LayoutTests/fast/alignment/parse-justify-items.html b/LayoutTests/fast/alignment/parse-justify-items.html
index 3c0f09a4d4d60807b39fd1cf0461198245eb8517..0a8c7b27a94ecb9d05871f265432b80ee7749a57 100644
--- a/LayoutTests/fast/alignment/parse-justify-items.html
+++ b/LayoutTests/fast/alignment/parse-justify-items.html
@@ -295,38 +295,27 @@ checkBadValues(element, "justifyItems", "justify-items", "legacy left right");
debug("");
debug("Test the value 'initial'");
-checkInitialValues(element, "justifyItems", "justify-items");
+checkInitialValues(element, "justifyItems", "justify-items", "", "legacy center");
debug("");
debug("Test the value 'initial' for grid containers");
-checkInitialValues(element, "justifyItems", "justify-items", "grid");
+checkInitialValues(element, "justifyItems", "justify-items", "grid", "left safe");
debug("");
debug("Test the value 'initial' for flex containers");
-checkInitialValues(element, "justifyItems", "justify-items", "flex");
+checkInitialValues(element, "justifyItems", "justify-items", "flex", "right true");
debug("");
debug("Test the value 'inherit'");
-parentElement = document.createElement("div");
-document.body.appendChild(parentElement);
-parentElement.style.justifyItems = "end";
-checkValues(parentElement, "justifyItems", "justify-items", "end", "end");
-
-element = document.createElement("div");
-parentElement.appendChild(element);
-element.style.justifyItems = "inherit";
-checkValues(element, "justifyItems", "justify-items", "inherit", "end");
+checkInheritValues(element, "justifyItems", "justify-items", "end");
+checkInheritValues(element, "justifyItems", "justify-items", "left safe");
+checkInheritValues(element, "justifyItems", "justify-items", "legacy center");
debug("");
debug("Test the value 'legacy'");
-parentElement = document.createElement("div");
-document.body.appendChild(parentElement);
-parentElement.style.justifyItems = "legacy right";
-checkValues(parentElement, "justifyItems", "justify-items", "legacy right", "legacy right");
-
-element = document.createElement("div");
-parentElement.appendChild(element);
-checkValues(element, "justifyItems", "justify-items", "", "legacy right");
+checkLegacyValues(element, "justifyItems", "justify-items", "legacy left");
+checkLegacyValues(element, "justifyItems", "justify-items", "legacy center");
+checkLegacyValues(element, "justifyItems", "justify-items", "legacy right");
</script>
</body>
« no previous file with comments | « no previous file | LayoutTests/fast/alignment/parse-justify-items-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698