Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: LayoutTests/fast/alignment/resources/alignment-parsing-utils.js

Issue 361113002: Properly managing overlfow-aligment for inherit and initial. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Applied suggested changes. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/alignment/resources/alignment-parsing-utils.js
diff --git a/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js b/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js
index 54add53c84d1a74350f7c0558afeb800591c4b28..4670fc8fd6795d728370861b7459f9820bdcd057 100644
--- a/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js
+++ b/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js
@@ -8,20 +8,44 @@ function checkValues(element, property, propertyID, value, computedValue)
function checkBadValues(element, property, propertyID, value)
{
- element.style.justifyItems = value;
- checkValues(element, property, propertyID, "", "start");
+ element.style.justifyItems = value;
+ checkValues(element, property, propertyID, "", "start");
}
-function checkInitialValues(element, property, propertyID, display)
+function checkInitialValues(element, property, propertyID, display, value)
{
- var initial = "start";
- if (display == "grid" || display == "flex") {
- element.style.display = display;
- initial = "stretch";
- }
+ var initial = "start";
+ if (display == "grid" || display == "flex") {
+ element.style.display = display;
+ initial = "stretch";
+ }
- element.style.justifyItems = "center";
- checkValues(element, property, propertyID, "center", "center");
- element.style.justifyItems = "initial";
- checkValues(element, property, propertyID, "initial", initial);
+ element.style.justifyItems = value;
+ checkValues(element, property, propertyID, value, value);
+ element.style.justifyItems = "initial";
+ checkValues(element, property, propertyID, "initial", initial);
+}
+
+function checkInheritValues(element, property, propertyID, value)
+{
+ parentElement = document.createElement("div");
+ document.body.appendChild(parentElement);
+ parentElement.style.justifyItems = value;
+ checkValues(parentElement, property, propertyID, value, value);
+
+ element = document.createElement("div");
+ parentElement.appendChild(element);
+ element.style.justifyItems = "inherit";
+ checkValues(element, property, propertyID, "inherit", value);
+}
+
+function checkLegacyValues(element, property, propertyID, value)
+{
+ document.body.appendChild(parentElement);
+ parentElement.style.justifyItems = value;
+ checkValues(parentElement, property, propertyID, value, value);
+
+ element = document.createElement("div");
+ parentElement.appendChild(element);
+ checkValues(element, property, propertyID, "", value);
}

Powered by Google App Engine
This is Rietveld 408576698