[CSS Grid Layout] Add element.style coverage for grid-auto-flow

[CSS Grid Layout] Add element.style coverage for grid-auto-flow

As follow-up patch for r177258 we're adding new test cases for
grid-auto-flow to check the correct behavior of element.style.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178187

[Manuel Rego, 2014-07-01 07:56:05]

As requested in https://codereview.chromium.org/333563003/#msg4
adding test coverage for element.style in grid-auto-flow-get-set.html
layout test.

[Julien - ping for review, 2014-07-15 01:10:03]

https://codereview.chromium.org/360233002/diff/1/LayoutTests/fast/css-grid-la...
File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (right):

https://codereview.chromium.org/360233002/diff/1/LayoutTests/fast/css-grid-la...
LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:209:
shouldBe("element.style.gridAutoFlow", "''");
Shouldn't we return row here to match getComputedStyle?

[Manuel Rego, 2014-07-15 09:28:29]

On 2014/07/15 01:10:03, Julien Chaffraix - PST wrote:
>
https://codereview.chromium.org/360233002/diff/1/LayoutTests/fast/css-grid-la...
> File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (right):
> 
>
https://codereview.chromium.org/360233002/diff/1/LayoutTests/fast/css-grid-la...
> LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:209:
> shouldBe("element.style.gridAutoFlow", "''");
> Shouldn't we return row here to match getComputedStyle?

I don't think so. Other properties like "position", "flex-direction", etc.
behave
exactly the same.

For example, checking position in the body element returns:
document.body.style.position: ""
window.getComputedStyle(document.body, '').getPropertyValue('position'):
"static"

And if you try to change it by a wrong value like "test" it returns the same.

[Julien - ping for review, 2014-07-15 15:09:20]

On 2014/07/15 at 09:28:29, rego wrote:
> On 2014/07/15 01:10:03, Julien Chaffraix - PST wrote:
> >
https://codereview.chromium.org/360233002/diff/1/LayoutTests/fast/css-grid-la...
> > File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (right):
> > 
> >
https://codereview.chromium.org/360233002/diff/1/LayoutTests/fast/css-grid-la...
> > LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:209:
> > shouldBe("element.style.gridAutoFlow", "''");
> > Shouldn't we return row here to match getComputedStyle?
> 
> I don't think so. Other properties like "position", "flex-direction", etc.
behave
> exactly the same.
> 
> For example, checking position in the body element returns:
> document.body.style.position: ""
> window.getComputedStyle(document.body, '').getPropertyValue('position'):
"static"
> 
> And if you try to change it by a wrong value like "test" it returns the same.

OK, LGTM

[Julien - ping for review, 2014-07-15 15:09:23]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-07-15 15:10:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rego@igalia.com/360233002/1

[commit-bot: I haz the power, 2014-07-15 16:11:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[commit-bot: I haz the power, 2014-07-15 17:13:41]

Change committed as 178187