Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax (Closed)

Created:
6 years, 6 months ago by Manuel Rego
Modified:
6 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr., Manuel Rego, rwlbuis, rune+blink, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Update grid-auto-flow to the new syntax In last versions of the spec grid-auto-flow syntax has changed. New syntax is: [ row | column ] && dense? | stack && [ row | column ]? Implemented parsing for new syntax and added/modified test cases in current layout tests. Adapted code to keep the current behavior using "stack" as if it was "none" in the previous syntax. This should be fixed in a follow-up patch once "stack" is implemented. Also "dense" needs to be reviewed. Right now auto-placement algorithm is always "dense" and never "sparse". BUG=384099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177258

Patch Set 1 #

Patch Set 2 : Rebased patch #

Patch Set 3 : Small fix in add/removeChild to avoid dirtying the grid in stack #

Total comments: 10

Patch Set 4 : New version #

Total comments: 3

Patch Set 5 : Patch for landing #

Patch Set 6 : Fix missing tests #

Patch Set 7 : Trying to fix win_blink_rel #

Patch Set 8 : Attempt 2 to fix win_blink_rel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -127 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html View 1 2 3 1 chunk +144 lines, -12 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt View 1 2 3 1 chunk +35 lines, -6 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-update.html View 2 chunks +5 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-update-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-z-index-stacking-context.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html View 3 chunks +44 lines, -14 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt View 7 chunks +52 lines, -16 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid.css View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/ietestcenter/css3/grid/grid-column-002.htm View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/ietestcenter/css3/grid/grid-column-003.htm View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 1 chunk +36 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 chunks +51 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 2 3 5 chunks +8 lines, -10 lines 0 comments Download
M Source/core/rendering/style/GridResolvedPosition.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 3 4 7 1 chunk +20 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleGridData.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Manuel Rego
6 years, 6 months ago (2014-06-12 13:45:39 UTC) #1
Julien - ping for review
https://codereview.chromium.org/333563003/diff/40001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (right): https://codereview.chromium.org/333563003/diff/40001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html#newcode32 LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:32: grid-auto-flow: inherit; Inherit is always a valid keyword for ...
6 years, 5 months ago (2014-06-27 17:44:54 UTC) #2
Manuel Rego
Thanks for the review. I'm uploading a new patch addressing your comments. https://codereview.chromium.org/333563003/diff/40001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html ...
6 years, 5 months ago (2014-06-27 22:43:51 UTC) #3
Julien - ping for review
lgtm https://codereview.chromium.org/333563003/diff/60001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (right): https://codereview.chromium.org/333563003/diff/60001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html#newcode103 LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:103: shouldBe("window.getComputedStyle(gridAutoFlowColumnDense, '').getPropertyValue('grid-auto-flow')", "'column dense'"); Nit: We should test ...
6 years, 5 months ago (2014-06-29 01:02:25 UTC) #4
Manuel Rego
Thanks for the review. https://codereview.chromium.org/333563003/diff/60001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html File LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (right): https://codereview.chromium.org/333563003/diff/60001/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html#newcode103 LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:103: shouldBe("window.getComputedStyle(gridAutoFlowColumnDense, '').getPropertyValue('grid-auto-flow')", "'column dense'"); Ok, ...
6 years, 5 months ago (2014-06-30 09:44:52 UTC) #5
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 5 months ago (2014-06-30 09:44:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/333563003/80001
6 years, 5 months ago (2014-06-30 09:45:25 UTC) #7
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 5 months ago (2014-06-30 10:29:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/333563003/100001
6 years, 5 months ago (2014-06-30 10:29:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-30 11:33:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 12:14:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14560)
6 years, 5 months ago (2014-06-30 12:14:30 UTC) #12
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 5 months ago (2014-06-30 22:45:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/333563003/140001
6 years, 5 months ago (2014-06-30 22:46:28 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-30 23:55:47 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 00:46:05 UTC) #16
Message was sent while issue was closed.
Change committed as 177258

Powered by Google App Engine
This is Rietveld 408576698