Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html

Issue 360233002: [CSS Grid Layout] Add element.style coverage for grid-auto-flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html b/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html
index e78846e4ffb4b796423319e4d9ce5efcea1e7346..0bb33ee7734dee3a0850e869d5e54ed6367825a8 100644
--- a/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html
@@ -168,26 +168,37 @@
debug("");
debug("Test getting and setting grid-auto-flow through JS");
element.style.gridAutoFlow = "column";
+ shouldBe("element.style.gridAutoFlow", "'column'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'column'");
element.style.gridAutoFlow = "column dense";
+ shouldBe("element.style.gridAutoFlow", "'column dense'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'column dense'");
element.style.gridAutoFlow = "row dense";
+ shouldBe("element.style.gridAutoFlow", "'row dense'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row dense'");
element.style.gridAutoFlow = "dense column";
+ shouldBe("element.style.gridAutoFlow", "'dense column'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'column dense'");
element.style.gridAutoFlow = "dense row";
+ shouldBe("element.style.gridAutoFlow", "'dense row'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row dense'");
element.style.gridAutoFlow = "row";
+ shouldBe("element.style.gridAutoFlow", "'row'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
element.style.gridAutoFlow = "stack";
+ shouldBe("element.style.gridAutoFlow", "'stack'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'stack row'");
element.style.gridAutoFlow = "stack column";
+ shouldBe("element.style.gridAutoFlow", "'stack column'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'stack column'");
element.style.gridAutoFlow = "stack row";
+ shouldBe("element.style.gridAutoFlow", "'stack row'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'stack row'");
element.style.gridAutoFlow = "column stack";
+ shouldBe("element.style.gridAutoFlow", "'column stack'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'stack column'");
element.style.gridAutoFlow = "row stack";
+ shouldBe("element.style.gridAutoFlow", "'row stack'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'stack row'");
debug("");
@@ -195,22 +206,29 @@
element = document.createElement("div");
document.body.appendChild(element);
element.style.gridAutoFlow = "noone";
+ shouldBe("element.style.gridAutoFlow", "''");
Julien - ping for review 2014/07/15 01:10:03 Shouldn't we return row here to match getComputedS
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
element.style.gridAutoFlow = "dense";
+ shouldBe("element.style.gridAutoFlow", "''");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
element.style.gridAutoFlow = "column column";
+ shouldBe("element.style.gridAutoFlow", "''");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
element.style.gridAutoFlow = "dense column stack";
+ shouldBe("element.style.gridAutoFlow", "''");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
element.style.gridAutoFlow = "dense row stack";
+ shouldBe("element.style.gridAutoFlow", "''");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
element.style.gridAutoFlow = "stack row row";
+ shouldBe("element.style.gridAutoFlow", "''");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
debug("");
debug("Test setting grid-auto-flow to 'initial' through JS");
// Reusing the value so that we can check that it is set back to its initial value.
element.style.gridAutoFlow = "initial";
+ shouldBe("element.style.gridAutoFlow", "'initial'");
shouldBe("window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow')", "'row'");
</script>
</body>
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698