Issue 359453002: Let FullscreenElementStack methods take references where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 359453002: Let FullscreenElementStack methods take references where possible (Closed)

Created:
6 years, 6 months ago by philipj_slow

Modified:
6 years, 6 months ago

Reviewers:
falken, acolwell GONE FROM CHROMIUM

CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, blink-reviews-html_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Let FullscreenElementStack methods take references where possible The main motivation is requestFullScreenForElement, which handled the Element* argument being null even though there's no way that could happen. The fallback to document()->documentElement() was unreachable. Get rid of fullScreenIsAllowedForElement since it was only used in a single place. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176968

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -42 lines)			Patch
M	Source/core/dom/Element.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/FullscreenElementStack.h	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/core/dom/FullscreenElementStack.cpp	View	9 chunks	+16 lines, -27 lines	0 comments	Download
M	Source/core/dom/RenderTreeBuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/shadow/MediaControlElements.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

PTAL. Note I stopped at the edge of FullscreenElementStack. If this change is OK, I ...

6 years, 6 months ago (2014-06-25 20:20:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/359453002/1

6 years, 6 months ago (2014-06-26 07:00:49 UTC) #4

Message was sent while issue was closed.

Change committed as 176968

Expand Messages | Collapse Messages