Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 359453002: Let FullscreenElementStack methods take references where possible (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, blink-reviews-html_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Let FullscreenElementStack methods take references where possible The main motivation is requestFullScreenForElement, which handled the Element* argument being null even though there's no way that could happen. The fallback to document()->documentElement() was unreachable. Get rid of fullScreenIsAllowedForElement since it was only used in a single place. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -42 lines) Patch
M Source/core/dom/Element.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 9 chunks +16 lines, -27 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL. Note I stopped at the edge of FullscreenElementStack. If this change is OK, I ...
6 years, 6 months ago (2014-06-25 20:20:07 UTC) #1
falken
lgtm
6 years, 6 months ago (2014-06-26 00:44:38 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-26 06:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/359453002/1
6 years, 6 months ago (2014-06-26 07:00:49 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 07:04:32 UTC) #5
Message was sent while issue was closed.
Change committed as 176968

Powered by Google App Engine
This is Rietveld 408576698