Source/core/html/HTMLMediaElement.cpp - Issue 359453002: Let FullscreenElementStack methods take references where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 359453002: Let FullscreenElementStack methods take references where possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 3a224309144a97d5f754f286a4d004141e738c9c..680c397cfcfd1bebf32d7475427bfa94ba021565 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3453,14 +3453,14 @@ void HTMLMediaElement::contextDestroyed()

bool HTMLMediaElement::isFullscreen() const

{

- return FullscreenElementStack::isActiveFullScreenElement(this);

+ return FullscreenElementStack::isActiveFullScreenElement(*this);

}

void HTMLMediaElement::enterFullscreen()

{

WTF_LOG(Media, "HTMLMediaElement::enterFullscreen");

- FullscreenElementStack::from(document()).requestFullScreenForElement(this, 0, FullscreenElementStack::ExemptIFrameAllowFullScreenRequirement);

+ FullscreenElementStack::from(document()).requestFullScreenForElement(*this, 0, FullscreenElementStack::ExemptIFrameAllowFullScreenRequirement);

}

void HTMLMediaElement::exitFullscreen()