Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: Source/core/dom/FullscreenElementStack.h

Issue 359453002: Let FullscreenElementStack methods take references where possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/FullscreenElementStack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/FullscreenElementStack.h
diff --git a/Source/core/dom/FullscreenElementStack.h b/Source/core/dom/FullscreenElementStack.h
index 852812a70d4a3652909905bdeb5e449ffb7a36c4..46c9d052e066c1a308cd2495606ffa6a1fd068e0 100644
--- a/Source/core/dom/FullscreenElementStack.h
+++ b/Source/core/dom/FullscreenElementStack.h
@@ -56,14 +56,14 @@ public:
static Element* fullscreenElementFrom(Document&);
static Element* currentFullScreenElementFrom(Document&);
static bool isFullScreen(Document&);
- static bool isActiveFullScreenElement(const Element*);
+ static bool isActiveFullScreenElement(const Element&);
enum FullScreenCheckType {
EnforceIFrameAllowFullScreenRequirement,
ExemptIFrameAllowFullScreenRequirement,
};
- void requestFullScreenForElement(Element*, unsigned short flags, FullScreenCheckType);
+ void requestFullScreenForElement(Element&, unsigned short flags, FullScreenCheckType);
void webkitCancelFullScreen();
void webkitWillEnterFullScreenForElement(Element*);
@@ -77,10 +77,9 @@ public:
void clearFullscreenElementStack();
void popFullscreenElementStack();
- void pushFullscreenElementStack(Element*);
- void addDocumentToFullScreenChangeEventQueue(Document*);
+ void pushFullscreenElementStack(Element&);
+ void addDocumentToFullScreenChangeEventQueue(Document&);
- bool fullScreenIsAllowedForElement(Element*) const;
void fullScreenElementRemoved();
void removeFullScreenElementOfSubtree(Node*, bool amongChildrenOnly = false);
@@ -119,9 +118,9 @@ private:
RefPtr<RenderStyle> m_savedPlaceholderRenderStyle;
};
-inline bool FullscreenElementStack::isActiveFullScreenElement(const Element* element)
+inline bool FullscreenElementStack::isActiveFullScreenElement(const Element& element)
{
- FullscreenElementStack* controller = fromIfExists(element->document());
+ FullscreenElementStack* controller = fromIfExists(element.document());
if (!controller)
return false;
return controller->webkitIsFullScreen() && controller->webkitCurrentFullScreenElement() == element;
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/FullscreenElementStack.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698