Source/core/dom/RenderTreeBuilder.cpp - Issue 359453002: Let FullscreenElementStack methods take references where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/RenderTreeBuilder.cpp

Issue 359453002: Let FullscreenElementStack methods take references where possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/RenderTreeBuilder.cpp

diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp

index 974a1fa5c53f6322ffb0105d4af4db412e952fc8..827237d75506c71db8f163c4f17ace112d9b7b30 100644

--- a/Source/core/dom/RenderTreeBuilder.cpp

+++ b/Source/core/dom/RenderTreeBuilder.cpp

@@ -132,7 +132,7 @@ void RenderTreeBuilder::createRendererForElementIfNeeded()

element->setRenderer(newRenderer);

newRenderer->setStyle(&style); // setStyle() can depend on renderer() already being set.

- if (FullscreenElementStack::isActiveFullScreenElement(element)) {

+ if (FullscreenElementStack::isActiveFullScreenElement(*element)) {

newRenderer = RenderFullScreen::wrapRenderer(newRenderer, parentRenderer, &element->document());

if (!newRenderer)

return;

« no previous file with comments | « Source/core/dom/FullscreenElementStack.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »