Issue 352693003: Implement HTTP/2 priority tree structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352693003: Implement HTTP/2 priority tree structure. (Closed)

Created:
6 years, 6 months ago by Johnny

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Implement HTTP/2 priority tree structure. This lands server change 69391145 by mlavan. BUG=

Patch Set 2 : Compile fixes. #

Total comments: 5

Patch Set 3 : Use public HTTP/2 URL. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+959 lines, -0 lines)			Patch
M	net/net.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	net/spdy/spdy_priority_tree.h	View	1 2	1 chunk	+558 lines, -0 lines	0 comments	Download
A	net/spdy/spdy_priority_tree_test.cc	View		1 chunk	+399 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/352693003/diff/20001/net/spdy/spdy_priority_tree.h File net/spdy/spdy_priority_tree.h (right): https://codereview.chromium.org/352693003/diff/20001/net/spdy/spdy_priority_tree.h#newcode22 net/spdy/spdy_priority_tree.h:22: // defined in this document: http://go/http2-spec Consider a ...

6 years, 6 months ago (2014-06-25 23:22:58 UTC) #2

Johnny

6 years, 6 months ago (2014-06-26 16:09:37 UTC) #3

https://codereview.chromium.org/352693003/diff/20001/net/spdy/spdy_priority_t...
File net/spdy/spdy_priority_tree.h (right):

https://codereview.chromium.org/352693003/diff/20001/net/spdy/spdy_priority_t...
net/spdy/spdy_priority_tree.h:22: // defined in this document:
http://go/http2-spec
On 2014/06/25 23:22:58, Ryan Hamilton wrote:
> Consider a public URL here.

Done.

https://codereview.chromium.org/352693003/diff/20001/net/spdy/spdy_priority_t...
net/spdy/spdy_priority_tree.h:82: int num_nodes() const;
On 2014/06/25 23:22:58, Ryan Hamilton wrote:
> Should this be size_t?

I also think it ought to be, but am leaving as-is to avoid future merge
conflicts in signed-ness of unit tests.

This class will probably see further changes before it's integrated into
Chromium.