DevTools: Nuke Dominators view from heap profiler.

DevTools: Nuke Dominators view from heap profiler.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177058

[alph, 2014-06-24 13:58:16]

ptal

[loislo, 2014-06-24 14:14:19]

lgtm with comment

let's postpone it until after IO

[alph, 2014-06-26 11:23:16]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-06-26 11:30:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alph@chromium.org/352603003/1

[commit-bot: I haz the power, 2014-06-26 11:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 11:31:16]

Failed to apply patch for
Source/devtools/front_end/profiler/HeapSnapshotView.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/profiler/HeapSnapshotView.js
  Hunk #1 FAILED at 79.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/profiler/HeapSnapshotView.js.rej

Patch:       Source/devtools/front_end/profiler/HeapSnapshotView.js
Index: Source/devtools/front_end/profiler/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotView.js
b/Source/devtools/front_end/profiler/HeapSnapshotView.js
index
33148fcd4b15faf650630d5731fa7a543e978054..458be7b706d1e331c6811795cd4453e717b1d19f
100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotView.js
@@ -79,12 +79,6 @@ WebInspector.HeapSnapshotView = function(dataDisplayDelegate,
profile)
     this._diffDataGrid.show(this._diffView.element);
    
this._diffDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode,
this._selectionChanged, this);
 
-    this._dominatorView = new WebInspector.VBox();
-    this._dominatorView.setMinimumSize(50, 25);
-    this._dominatorDataGrid = new
WebInspector.HeapSnapshotDominatorsDataGrid(dataDisplayDelegate);
-    this._dominatorDataGrid.show(this._dominatorView.element);
-   
this._dominatorDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode,
this._selectionChanged, this);
-
     if (WebInspector.experimentsSettings.heapAllocationProfiler.isEnabled() &&
profile.profileType() ===
WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType) {
         this._allocationView = new WebInspector.VBox();
         this._allocationView.setMinimumSize(50, 25);
@@ -138,8 +132,6 @@ WebInspector.HeapSnapshotView =
function(dataDisplayDelegate, profile)
     if (profile.profileType() !==
WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType)
         this._perspectives.push(new
WebInspector.HeapSnapshotView.ComparisonPerspective());
     this._perspectives.push(new
WebInspector.HeapSnapshotView.ContainmentPerspective());
-    if (WebInspector.settings.showAdvancedHeapSnapshotProperties.get())
-        this._perspectives.push(new
WebInspector.HeapSnapshotView.DominatorPerspective());
     if (this._allocationView)
         this._perspectives.push(new
WebInspector.HeapSnapshotView.AllocationPerspective());
     if (WebInspector.experimentsSettings.heapSnapshotStatistics.isEnabled())
@@ -368,40 +360,6 @@
WebInspector.HeapSnapshotView.ContainmentPerspective.prototype = {
  * @constructor
  * @extends {WebInspector.HeapSnapshotView.Perspective}
  */
-WebInspector.HeapSnapshotView.DominatorPerspective = function()
-{
-    WebInspector.HeapSnapshotView.Perspective.call(this, 
WebInspector.UIString("Dominators"));
-}
-
-WebInspector.HeapSnapshotView.DominatorPerspective.prototype = {
-    /**
-     * @override
-     * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
-     */
-    activate: function(heapSnapshotView)
-    {
-       
heapSnapshotView._dominatorView.show(heapSnapshotView._splitView.mainElement());
-       
heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sidebarElement());
-        heapSnapshotView._splitView.show(heapSnapshotView.element);
-    },
-
-    /**
-     * @override
-     * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
-     * @return {?WebInspector.DataGrid}
-     */
-    masterGrid: function(heapSnapshotView)
-    {
-        return heapSnapshotView._dominatorDataGrid;
-    },
-
-   __proto__: WebInspector.HeapSnapshotView.Perspective.prototype
-}
-
-/**
- * @constructor
- * @extends {WebInspector.HeapSnapshotView.Perspective}
- */
 WebInspector.HeapSnapshotView.AllocationPerspective = function()
 {
     WebInspector.HeapSnapshotView.Perspective.call(this, 
WebInspector.UIString("Allocation"));

[alph, 2014-06-26 12:25:33]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-06-26 12:26:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alph@chromium.org/352603003/20001

[commit-bot: I haz the power, 2014-06-26 13:28:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[commit-bot: I haz the power, 2014-06-27 04:06:44]

Change committed as 177058