Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js

Issue 352603003: DevTools: Nuke Dominators view from heap profiler. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/profiler/ProfilesPanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
diff --git a/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js b/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
index 910b5a33f34c5d5945600b30584d35784e5ec810..6bdb5f8f9bd3a577734221c58f709d513478e7bd 100644
--- a/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
+++ b/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
@@ -1083,17 +1083,6 @@ WebInspector.HeapSnapshot.prototype = {
},
/**
- * @param {!WebInspector.HeapSnapshotNode} node
- * @return {!Uint32Array}
- */
- _dominatedNodesOfNode: function(node)
- {
- var dominatedIndexFrom = this._getDominatedIndex(node.nodeIndex);
- var dominatedIndexTo = this._getDominatedIndex(node._nextNodeIndex());
- return this._dominatedNodes.subarray(dominatedIndexFrom, dominatedIndexTo);
- },
-
- /**
* @param {!WebInspector.HeapSnapshotCommon.NodeFilter} nodeFilter
* @return {!Object.<string, !WebInspector.HeapSnapshotCommon.Aggregate>}
*/
@@ -1869,23 +1858,6 @@ WebInspector.HeapSnapshot.prototype = {
},
/**
- * @param {string} snapshotObjectId
- * @return {?Array.<string>}
- */
- dominatorIdsForNode: function(snapshotObjectId)
- {
- var node = this._nodeForSnapshotObjectId(snapshotObjectId);
- if (!node)
- return null;
- var result = [];
- while (!node.isRoot()) {
- result.push(node.id());
- node.nodeIndex = node.dominatorIndex();
- }
- return result;
- },
-
- /**
* @param {number} nodeIndex
* @return {!WebInspector.HeapSnapshotEdgesProvider}
*/
@@ -1977,16 +1949,6 @@ WebInspector.HeapSnapshot.prototype = {
},
/**
- * @param {number} nodeIndex
- * @return {!WebInspector.HeapSnapshotNodesProvider}
- */
- createNodesProviderForDominator: function(nodeIndex)
- {
- var node = this.createNode(nodeIndex);
- return new WebInspector.HeapSnapshotNodesProvider(this, null, this._dominatedNodesOfNode(node));
- },
-
- /**
* @return {number}
*/
_maxJsNodeId: function()
« no previous file with comments | « Source/devtools/front_end/profiler/ProfilesPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698