Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 352603003: DevTools: Nuke Dominators view from heap profiler. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotView.js b/Source/devtools/front_end/profiler/HeapSnapshotView.js
index 52907528ba49bf07917a4693ca77958075e3d34e..0b324c1ff2f8afaeac2a897e04a3477caa4497f0 100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotView.js
@@ -79,12 +79,6 @@ WebInspector.HeapSnapshotView = function(dataDisplayDelegate, profile)
this._diffDataGrid.show(this._diffView.element);
this._diffDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
- this._dominatorView = new WebInspector.VBox();
- this._dominatorView.setMinimumSize(50, 25);
- this._dominatorDataGrid = new WebInspector.HeapSnapshotDominatorsDataGrid(dataDisplayDelegate);
- this._dominatorDataGrid.show(this._dominatorView.element);
- this._dominatorDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
-
if (profile._hasAllocationStacks) {
this._allocationView = new WebInspector.VBox();
this._allocationView.setMinimumSize(50, 25);
@@ -138,8 +132,6 @@ WebInspector.HeapSnapshotView = function(dataDisplayDelegate, profile)
if (profile.profileType() !== WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType)
this._perspectives.push(new WebInspector.HeapSnapshotView.ComparisonPerspective());
this._perspectives.push(new WebInspector.HeapSnapshotView.ContainmentPerspective());
- if (WebInspector.settings.showAdvancedHeapSnapshotProperties.get())
- this._perspectives.push(new WebInspector.HeapSnapshotView.DominatorPerspective());
if (this._allocationView)
this._perspectives.push(new WebInspector.HeapSnapshotView.AllocationPerspective());
if (WebInspector.experimentsSettings.heapSnapshotStatistics.isEnabled())
@@ -368,40 +360,6 @@ WebInspector.HeapSnapshotView.ContainmentPerspective.prototype = {
* @constructor
* @extends {WebInspector.HeapSnapshotView.Perspective}
*/
-WebInspector.HeapSnapshotView.DominatorPerspective = function()
-{
- WebInspector.HeapSnapshotView.Perspective.call(this, WebInspector.UIString("Dominators"));
-}
-
-WebInspector.HeapSnapshotView.DominatorPerspective.prototype = {
- /**
- * @override
- * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
- */
- activate: function(heapSnapshotView)
- {
- heapSnapshotView._dominatorView.show(heapSnapshotView._splitView.mainElement());
- heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sidebarElement());
- heapSnapshotView._splitView.show(heapSnapshotView.element);
- },
-
- /**
- * @override
- * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
- * @return {?WebInspector.DataGrid}
- */
- masterGrid: function(heapSnapshotView)
- {
- return heapSnapshotView._dominatorDataGrid;
- },
-
- __proto__: WebInspector.HeapSnapshotView.Perspective.prototype
-}
-
-/**
- * @constructor
- * @extends {WebInspector.HeapSnapshotView.Perspective}
- */
WebInspector.HeapSnapshotView.AllocationPerspective = function()
{
WebInspector.HeapSnapshotView.Perspective.call(this, WebInspector.UIString("Allocation"));
« no previous file with comments | « Source/devtools/front_end/profiler/HeapSnapshotProxy.js ('k') | Source/devtools/front_end/profiler/ProfilesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698