Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 352603003: DevTools: Nuke Dominators view from heap profiler. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js b/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
index 3a2223f1fbd2f44c3b771480b64abc640eccd6c8..9e9cbce672b3d249995ac446d2c55a8de885326c 100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
@@ -1408,111 +1408,6 @@ WebInspector.HeapSnapshotDiffNode.prototype = {
/**
* @constructor
- * @extends {WebInspector.HeapSnapshotGenericObjectNode}
- * @param {!WebInspector.HeapSnapshotSortableDataGrid} dataGrid
- * @param {!WebInspector.HeapSnapshotCommon.Node} node
- */
-WebInspector.HeapSnapshotDominatorObjectNode = function(dataGrid, node)
-{
- WebInspector.HeapSnapshotGenericObjectNode.call(this, dataGrid, node);
- this.updateHasChildren();
-};
-
-WebInspector.HeapSnapshotDominatorObjectNode.prototype = {
- /**
- * @override
- * @return {!WebInspector.HeapSnapshotProviderProxy}
- */
- createProvider: function()
- {
- return this._dataGrid.snapshot.createNodesProviderForDominator(this.snapshotNodeIndex);
- },
-
- /**
- * @param {number} snapshotObjectId
- * @param {function(?WebInspector.DataGridNode)} callback
- */
- retrieveChildBySnapshotObjectId: function(snapshotObjectId, callback)
- {
- /**
- * @this {WebInspector.HeapSnapshotDominatorObjectNode}
- */
- function didExpand()
- {
- this._provider().nodePosition(snapshotObjectId, didGetNodePosition.bind(this));
- }
-
- /**
- * @this {WebInspector.HeapSnapshotDominatorObjectNode}
- */
- function didGetNodePosition(nodePosition)
- {
- if (nodePosition === -1) {
- this.collapse();
- callback(null);
- } else
- this._populateChildren(nodePosition, null, didPopulateChildren.bind(this, nodePosition));
- }
-
- /**
- * @this {WebInspector.HeapSnapshotDominatorObjectNode}
- */
- function didPopulateChildren(nodePosition)
- {
- var child = this.childForPosition(nodePosition);
- callback(child);
- }
-
- // Make sure hasChildren flag is updated before expanding this node as updateHasChildren response
- // may not have been received yet.
- this.hasChildren = true;
- this.expandWithoutPopulate(didExpand.bind(this));
- },
-
- _createChildNode: function(item)
- {
- return new WebInspector.HeapSnapshotDominatorObjectNode(this._dataGrid, item);
- },
-
- /**
- * @param {!WebInspector.HeapSnapshotCommon.Node} node
- * @return {number}
- */
- _childHashForEntity: function(node)
- {
- return node.id;
- },
-
- /**
- * @param {!WebInspector.HeapSnapshotDominatorObjectNode} childNode
- * @return {number}
- */
- _childHashForNode: function(childNode)
- {
- return childNode.snapshotNodeId;
- },
-
- /**
- * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig}
- */
- comparator: function()
- {
- var sortAscending = this._dataGrid.isSortOrderAscending();
- var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
- var sortFields = {
- object: ["id", sortAscending, "retainedSize", false],
- shallowSize: ["selfSize", sortAscending, "id", true],
- retainedSize: ["retainedSize", sortAscending, "id", true]
- }[sortColumnIdentifier];
- return WebInspector.HeapSnapshotGridNode.createComparator(sortFields);
- },
-
- __proto__: WebInspector.HeapSnapshotGenericObjectNode.prototype
-}
-
-
-/**
- * @constructor
* @extends {WebInspector.HeapSnapshotGridNode}
* @param {!WebInspector.AllocationDataGrid} dataGrid
* @param {!WebInspector.HeapSnapshotCommon.SerializedAllocationNode} data
« no previous file with comments | « Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js ('k') | Source/devtools/front_end/profiler/HeapSnapshotProxy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698